drivers: adc: stm32f1x serie has no overrun interrupt #56016
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At adc start_read, the OVR flag when it exists in ADC peripheral --> not available on the stm32f1 serie. Signed-off-by: Francois Ramu <[email protected]>
zephyrbot
added
platform: STM32
zephyrbot
requested review from
ABOSTM,
GeorgeCGV,
anangl,
erwango and
gautierg-st
FRASTM
requested review from
carlescufi
and removed request for
ABOSTM,
GeorgeCGV,
anangl,
erwango and
gautierg-st
heinwessels
suggested changes
Mar 21, 2023
| */ | ||
| adc_stm32_enable(adc); | ||
|
|
||
| #if !defined(CONFIG_SOC_SERIES_STM32F1X) |
Contributor
There was a problem hiding this comment.
Note, there's still two OVR instances in dma_callback which needs to be handled. This build isn't failing because there's no test build with the STM32F1+ADC+DMA. It's done correctly in my PR, but I can also close it in favour if this one if this comment is addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the adc_stm32 driver, at adc start_read(), the OVR flag when it exists in ADC peripheral --> not available on the stm32f1 serie.
Following the #52965
there was a regression (build error) on the stm32f1 serie:
The stm32f1x serie has no OVerRun interrupt.
A simple compilation Flag will fix the issue.
Signed-off-by: Francois Ramu [email protected]