Skip to content

Conversation

@heinwessels
Copy link
Contributor

STM32 ADC DMA support added in #52965 incorrectly assumed that all ADC devices have a OVR flag. This commit changes the driver to only account for it if it's found in the LL drivers.

@zephyrbot zephyrbot added platform: STM32 ST Micro STM32 area: ADC Analog-to-Digital Converter (ADC) labels Mar 21, 2023
@heinwessels
Copy link
Contributor Author

heinwessels commented Mar 21, 2023

Ah, I see there's another fix in the works, although IMO it's less portable. #56016

STM32 ADC DMA support added in zephyrproject-rtos#52965 incorrectly assumed
that all ADC devices have a OVR flag. This commit changes
the driver to only account for it if it's found in the
LL drivers.

Signed-off-by: Hein Wessels <[email protected]>
@heinwessels heinwessels force-pushed the stm32-adc-conditional-ovr-handling branch from 145827d to de91097 Compare March 21, 2023 08:53
@heinwessels
Copy link
Contributor Author

Changed from using defined(LL_ADC_FLAG_OVR) to !defined(CONFIG_SOC_SERIES_STM32F1X). The stm32u5 has LL_ADC_FLAG_OVR defined, but doesn't have LL_ADC_ClearFlag_OVR. Similar to the other PR that fixes this issue.

@carlescufi carlescufi merged commit 36f592d into zephyrproject-rtos:main Mar 22, 2023
@heinwessels heinwessels deleted the stm32-adc-conditional-ovr-handling branch March 27, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ADC Analog-to-Digital Converter (ADC) platform: STM32 ST Micro STM32

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants