drivers: wifi/airoc: update airoc_wifi_host_buffer_get #72859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npal-cy
force-pushed
the
topic/update_airoc_wifi_host_buffer_get
branch
from
1ee2142 to
8d8f606
Compare
jukkar
reviewed
May 16, 2024
Member
jukkar
left a comment
jukkar
left a comment
There was a problem hiding this comment.
LGTM, just fix the compliance issue.
npal-cy
force-pushed
the
topic/update_airoc_wifi_host_buffer_get
branch
2 times, most recently
from
87a4f7c to
2a0c447
Compare
Contributor
Author
|
hi @jukkar can we merge this on? |
npal-cy
force-pushed
the
topic/update_airoc_wifi_host_buffer_get
branch
from
2a0c447 to
eda33b8
Compare
Update airoc_wifi_host_buffer_get function to set final buff size based on input “size” param. Update airoc_mgmt_send to use airoc_wifi_host_buffer_get instead net_buf_alloc_len. Signed-off-by: Nazar Palamar <[email protected]>
npal-cy
force-pushed
the
topic/update_airoc_wifi_host_buffer_get
branch
from
eda33b8 to
be896c9
Compare
ifyall
approved these changes
May 22, 2024
Member
|
@jukkar can you approve if happy? |
ifyall
approved these changes
Jun 12, 2024
Contributor
Author
|
Hi @jukkar, @carlescufi this one as well as #74203 is critical to be present in 3.7 releases. Could you help with review? |
jukkar
approved these changes
Jun 17, 2024
Member
|
@aescolar This is clearly a stabilisation fix. Why postpone it to v4.0.0? |
Contributor
|
Agreed, this should be marked 3.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update airoc_wifi_host_buffer_get function to set final buff size based on input “size” param.