Skip to content

wifi: airoc: misc update of airoc wifi driver #74203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 19, 2024
Merged

wifi: airoc: misc update of airoc wifi driver #74203

merged 4 commits into from
Aug 19, 2024

Conversation

@morihisa-momona
Copy link
Contributor

@morihisa-momona morihisa-momona commented Jun 13, 2024

  • FIX: STA fails to connect AP, of which security is open
  • FIX: SoftAP supports only OPEN and WPA2-PSK. Other scruity modes(e.g. WPA3-SAE, WPA-PSK) are not supported
  • FIX: When creating softap, interface is not recognized as up.
  • Add the support of join and leave of multicast address group

Signed-off-by: Morihisa Momona [email protected]

@zephyrbot zephyrbot added the area: Wi-Fi Wi-Fi label Jun 13, 2024
@github-actions
Copy link

github-actions bot commented Jun 13, 2024

Hello @morihisa-momona, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@morihisa-momona morihisa-momona force-pushed the topic/mm/misc_update_of_airoc_wifi_driver branch 4 times, most recently from 8f2dc5b to 6aca76b Compare June 14, 2024 10:03
npal-cy
npal-cy previously approved these changes Jun 17, 2024
View reviewed changes
@npal-cy npal-cy mentioned this pull request Jun 17, 2024
Merged
@npal-cy
Copy link
Contributor

npal-cy commented Jun 17, 2024

Hi @jukkar, @carlescufi those changes as well as #72859 are critical to be present in 3.7 releases. Could you help with review?

krish2718
krish2718 reviewed Jun 19, 2024
View reviewed changes
drivers/wifi/infineon/airoc_wifi.c Outdated
Copy link
Contributor

@krish2718 krish2718 Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused by the commit log, the existing code defaulted to WPA2-PSK is a passphrase is given, so, new code should check the user requested algo and reject with appropriate error, but I only see mapping here, am I missing something?

Copy link
Contributor Author

@morihisa-momona morihisa-momona Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I don't get your point well.
When I configured WPA3-SAE, original code configures WPA2-PSK since it check if pks_length is 0 or not.
Then, I modified to check security type in order to use WPA3-SAE. Am I missing anything.

Copy link
Contributor

@krish2718 krish2718 Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I understand that, but I was reading the commit log and it was matching older implementation. IIUC, the limitation in the chip is now gone and it supports all security algos? If yes, the fix is good, commit log can be re-worded.

@morihisa-momona morihisa-momona force-pushed the topic/mm/misc_update_of_airoc_wifi_driver branch from 6aca76b to 29f21c6 Compare July 1, 2024 08:43
npal-cy
npal-cy previously approved these changes Jul 2, 2024
View reviewed changes
@npal-cy npal-cy requested a review from krish2718 July 2, 2024 05:39
jukkar
jukkar reviewed Jul 2, 2024
View reviewed changes
drivers/wifi/infineon/airoc_wifi.c Outdated
Copy link
Member

@jukkar jukkar Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here for this if statement

Copy link
Contributor Author

@morihisa-momona morihisa-momona Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@morihisa-momona @npal-cy
wifi: airoc: FIX connection to AP with open security
6d4909f 
STA fails to connect AP, of which security is open.

Signed-off-by: Morihisa Momona <[email protected]>
@morihisa-momona @npal-cy
wifi: airoc: FIX Security modes of SoftAP
c5db656 
Updated security modes verification in ap_enable.
SoftAP supports following modes:
 - No security (WHD\_SECURITY\_OPEN)
 - WPA2-PSK security (WHD_SECURITY_WPA2_AES_PSK)
 - WPA3-SAE security (WHD_SECURITY_WPA3_SAE)

Signed-off-by: Morihisa Momona <[email protected]>
@morihisa-momona @npal-cy
wifi: airoc: FIX interface up (in softap)
453f125 
When creating softap, interface is not recognized as up.

Signed-off-by: Morihisa Momona <[email protected]>
@morihisa-momona morihisa-momona force-pushed the topic/mm/misc_update_of_airoc_wifi_driver branch 2 times, most recently from 4e38836 to e2b6eac Compare July 9, 2024 07:07
npal-cy
npal-cy previously approved these changes Jul 9, 2024
View reviewed changes
@npal-cy npal-cy requested a review from jukkar August 6, 2024 22:40
jukkar
jukkar reviewed Aug 7, 2024
View reviewed changes
drivers/wifi/infineon/airoc_wifi.c Outdated
Comment on lines 374 to 375
Copy link
Member

@jukkar jukkar Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is wrong

Copy link
Contributor Author

@morihisa-momona morihisa-momona Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@morihisa-momona
wifi: airoc: join/leave of multicast address
8c77c33 
Add the support of join and leave of multicast address group.

Signed-off-by: Morihisa Momona <[email protected]>
@morihisa-momona morihisa-momona force-pushed the topic/mm/misc_update_of_airoc_wifi_driver branch from e2b6eac to 8c77c33 Compare August 7, 2024 09:48
@npal-cy
Copy link
Contributor

npal-cy commented Aug 19, 2024

@krish2718 can you review comments and approve if ok?

@nashif nashif merged commit 9afc79d into zephyrproject-rtos:main Aug 19, 2024
@github-actions
Copy link

github-actions bot commented Aug 19, 2024

Hi @morihisa-momona!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jukkar jukkar jukkar approved these changes

@krish2718 krish2718 krish2718 approved these changes

@Kludentwo Kludentwo Awaiting requested review from Kludentwo

@rlubos rlubos Awaiting requested review from rlubos

+1 more reviewer

@npal-cy npal-cy npal-cy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jukkar jukkar

Labels

area: Wi-Fi Wi-Fi

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morihisa-momona @npal-cy @jukkar @krish2718 @nashif @zephyrbot