Skip to content

boards: arm: stm32h750b_dk: add support for display (fixed) #73107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

boards: arm: stm32h750b_dk: add support for display (fixed) #73107

wants to merge 3 commits into from

Conversation

@toonst
Copy link
Contributor

@toonst toonst commented May 21, 2024

Add support for display on stm32h750b_dk. samples/drivers/display is compiling and flashing correctly now. Previous PR is here: #67245 but, I can't reopen it.

Contains patch by pcornu, also tested by ajarmouni-st

@zephyrbot zephyrbot added the platform: STM32 ST Micro STM32 label May 21, 2024
@toonst toonst mentioned this pull request May 21, 2024
Closed
erwango
erwango reviewed May 22, 2024
View reviewed changes
boards/st/stm32h750b_dk/stm32h750b_dk.dts Outdated
Comment on lines 187 to 188
Copy link
Member

@erwango erwango May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question on these commented lies:
Will they be potentially useful ?
If yes, under which conditions ? -> A comment would be nice
if not, can we remove them ?

erwango
erwango requested changes May 22, 2024
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second commit doesn't look required.
Can you squash both ?

boards/st/stm32h750b_dk/Kconfig.stm32h750b_dk Outdated
Comment on lines +7 to +14
Copy link
Member

@erwango erwango May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already included in boards/arm/stm32h750b_dk/Kconfig.defconfig doesn't look required here.

@toonst toonst force-pushed the stm32h750b_dk_display branch from 8e11ab1 to f4197c1 Compare May 22, 2024 17:19
@zephyrbot zephyrbot added the area: Shields Shields (add-on boards) label May 22, 2024
@toonst toonst force-pushed the stm32h750b_dk_display branch from f4197c1 to 925c12b Compare May 22, 2024 17:22
toonst and others added 3 commits May 22, 2024 19:40
@toonst
boards: arm: stm32h750b_dk: add support for display
f9db7a6 
ltdc devicetree definition

Signed-off-by: Toon Stegen <[email protected]>
@toonst
boards: arm: stm32h750b_dk: add support for display
fb6e46d 
ltdc devicetree definition & external SDRAM selection
for the display buffer

Signed-off-by: Philippe Cornu <[email protected]>
Signed-off-by: Toon Stegen <[email protected]>
@ajarmouni-st @toonst
boards: stm32h750b_dk: flash with stm32cubeprogrammer
c9e74ba 
Add flashing with stm32cubeprogrammer.

Signed-off-by: Abderrahmane Jarmouni <[email protected]>
@toonst toonst force-pushed the stm32h750b_dk_display branch from 925c12b to c9e74ba Compare May 22, 2024 17:40
@ajarmouni-st
Copy link
Contributor

ajarmouni-st commented May 27, 2024

Hi @toonst you have a CI issue to be fixed

Error: See https://docs.zephyrproject.org/latest/guides/kconfig/index.html for more details.

 Undefined Kconfig symbols:

 warning: undefined symbol DISPLAY:

- Referenced at boards/st/stm[32](https://github.com/zephyrproject-rtos/zephyr/actions/runs/9195959793/job/25292938413?pr=73107#step:10:33)h750b_dk/Kconfig.stm32h750b_dk:11:

config MEMC
	default y
	depends on DISPLAY
Error: Process completed with exit code 1.

@ajarmouni-st
Copy link
Contributor

ajarmouni-st commented Jun 13, 2024

Hi @toonst can you rebase & incoporate changes directly from my branch https://github.com/ajarmouni-st/zephyr_dev/tree/dev_stm32h750b_dk_display ? Thanks!

@ajarmouni-st ajarmouni-st added this to the v3.7.0 milestone Jun 13, 2024
mathieuchopstm
mathieuchopstm reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides this:

boards/arm/stm32h750b_dk/Kconfig.defconfig
Copy link
Contributor

@mathieuchopstm mathieuchopstm Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a stray file (unless this is for HWMv1 compatibility?).
AFAIK, Kconfig should come from boards/st/stm32h750b_dk/Kconfig.stm32h750b_dk instead (which also contains this), so this file should probably be removed.

Copy link
Member

@erwango erwango Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch this file is not required indeed. Please remove.

erwango
erwango requested changes Jun 14, 2024
View reviewed changes
boards/arm/stm32h750b_dk/Kconfig.defconfig
Copy link
Member

@erwango erwango Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch this file is not required indeed. Please remove.

@erwango
Copy link
Member

erwango commented Jun 14, 2024

I've pushed @ajarmouni-st 's branch here: #73107

@aescolar aescolar modified the milestones: v3.7.0, v4.0.0 Jun 17, 2024
@aescolar
Copy link
Member

aescolar commented Jun 17, 2024

Bulk changing the milestone from everything which did not make it to the v3.7.0 freeze deadline
and which is not labeled as a bug or documentation (or does not appear clearly as only containing
a bug fix or a documentation change).
If you disagree about this change please add the milestone again.

Please note that until rc2 only PRs containing bug fixes, docs and tests can be merged.
After that and until release only bug fixes and docs changes.

Exceptions require approval by the release team and a vote by the TSC.
https://docs.zephyrproject.org/latest/project/release_process.html#stabilization-phase

@aescolar
Copy link
Member

aescolar commented Jun 17, 2024

@toonst rebase needed

@ajarmouni-st
Copy link
Contributor

ajarmouni-st commented Jun 27, 2024

Closed in favor of #74294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathieuchopstm mathieuchopstm mathieuchopstm left review comments

@erwango erwango erwango requested changes

@ajarmouni-st ajarmouni-st Awaiting requested review from ajarmouni-st

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@avisconti avisconti Awaiting requested review from avisconti

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@kartben kartben Awaiting requested review from kartben

Assignees

@erwango erwango

Labels

area: Display area: Shields Shields (add-on boards) platform: STM32 ST Micro STM32

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@toonst @ajarmouni-st @erwango @aescolar @mathieuchopstm @zephyrbot