tests: Bluetooth: Audio: Move role specific mocks files #73731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
audio_unittest_refactor
branch
3 times, most recently
from
ab43a09 to
39aef41
Compare
Thalley
force-pushed
the
audio_unittest_refactor
branch
2 times, most recently
from
f0d32b3 to
4cf2019
Compare
zephyrbot
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
asbjornsabo,
fredrikdanebjer,
jhedberg,
kruithofa,
larsgk,
niym-ot,
pin-zephyr and
sjanc
kruithofa
previously approved these changes
Jun 13, 2024
larsgk
previously approved these changes
Jun 13, 2024
Thalley
force-pushed
the
audio_unittest_refactor
branch
from
4cf2019 to
c05520b
Compare
jthm-ot
approved these changes
Jun 14, 2024
Thalley
force-pushed
the
audio_unittest_refactor
branch
from
c05520b to
4a55935
Compare
kruithofa
approved these changes
Jun 20, 2024
For the LE Audio unittests there exists a few mock files that implement mock versions, or callbacks, for some of the roles and features tested. These have been moved to where they are actually used, reducing the scope of these files. This both allows the individual tests to implement their own versions of it, but more importantly it prevents issues when adding tests for these roles. For example, due to the bap_unicast_client.c mock file, it is impossible to implement unit tests for the unicast client, as the functions are already defined. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
audio_unittest_refactor
branch
from
4a55935 to
72e7851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the LE Audio unittests there exists a few mock files
that implement mock versions, or callbacks, for some of the
roles and features tested.
These have been moved to where they are actually used,
reducing the scope of these files.
This both allows the individual tests to implement their own
versions of it, but more importantly it prevents issues when
adding tests for these roles. For example, due to the
bap_unicast_client.c mock file, it is impossible to implement
unit tests for the unicast client, as the functions are already
defined.