boards: add support for Artemis Nano from Sparkfun #76136
Conversation
|
Can you stop opening and closing the same PR 6 times? |
|
Dear @nordicjm, This is not exactly the same PR. I am trying to pass the CI and have managed to resolve a couple of issues related to documentation and trailing white spaces. However, I am unable to understand the cause of this last error, as the message is not informative. This is my first time contributing and attempting to add support for a new board. I apologize for any inconvenience and would appreciate any guidance you can provide. |
|
With PRs you update your commits and then you force push i.e. |
aaronyegx
left a comment
aaronyegx
left a comment
There was a problem hiding this comment.
Please exclude "merge" commit.
There was a problem hiding this comment.
use the proper board Kconfig symbol
There was a problem hiding this comment.
Sorry I did not get your command on this. Could you please explain it a bit?
There was a problem hiding this comment.
if(CONFIG_BOARD_ARTEMIS_NANO) would be used, but you can remove it entirely since board.cmake is only used if this board is used, so unless this board has multiple board targets the if can go
|
@AlienSarlak I see you mark multiple comments resolved but I do not find the updates. Do you push your updates? |
|
Dear @aaronyegx , You’re absolutely right; I marked the issues as resolved but haven’t pushed my branch yet. I wanted to address all the outstanding issues before pushing. Apologies for the delay—I’ve been quite busy lately. Thank you for your patience! |
AlienSarlak
force-pushed
the
boards/artemis_nano
branch
from
84c9189 to
ffdb199
Compare
|
@aaronyegx I have updated the branch |
|
@AlienSarlak don't make separate commit for code review, please squash them to previous ones |
AlienSarlak
force-pushed
the
boards/artemis_nano
branch
2 times, most recently
from
08df115 to
5533688
Compare
|
@AlienSarlak Please address the CI failures. |
Implemented support for the new board Artemis Nano from Sparkfun. Added support for the west flash to enable users to flash the board. Users should follow the documentation in the docs section of Zephyr for Artemis Nano. Signed-off-by: Ali Sarlak <[email protected]>
AlienSarlak
force-pushed
the
boards/artemis_nano
branch
from
5533688 to
6817fb7
Compare
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
Hi! I was planning on adding support for the Artemis Red Board. But I found this PR and I was wondering if I could take over and make it through for both, since it has common groundwork. |
7 participants
Implemented support for the new board Artemis Nano from Sparkfun. Added support for the west flash to enable users to flash the board. Users should follow the documentation in the docs section of Zephyr for Artemis Nano.