lis2dux12: fix temp conversion (and other issues) #76279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avisconti
added
bug
zephyrbot
requested review from
erwango,
jeppenodgaard,
jfischer-no,
kartben,
nashif,
tristan-google,
ubieda and
yperess
Extended the x-nucleo-iks4a1 shield standard sample adding lsm6dsv16x sensor die temperature display. Signed-off-by: Armando Visconti <[email protected]>
When setting the full scale through SENSOR_ATTR_FULL_SCALE the driver must convert the g value (i.e. one of 2g/4g/8g/16g) to the corrispondent sensor fs raw value. Signed-off-by: Armando Visconti <[email protected]>
The current implementation assumes that sensor odr and range are always configured in the Device Tree at compile time which might not be the case. Instead, application can set odr and range either at compile time through the DT or using SENSOR_ATTR_SAMPLING_FREQUENCY and SENSOR_ATTR_FULL_SCALE attributes at runtime, so each driver instance must keep trace of the latest values set and use them in the sensor APIs which require them (e.g. lis2dux12_mode_set). Signed-off-by: Armando Visconti <[email protected]>
Return to sensor_api i/f the temperature in Celsius instead of the register raw value in LSB. Fixes zephyrproject-rtos#75686 Signed-off-by: Armando Visconti <[email protected]>
fabiobaltieri
approved these changes
Jul 24, 2024
MaureenHelm
approved these changes
Jul 24, 2024
|
@avisconti does this fix need to be backported to v3.6? |
ubieda
reviewed
Jul 24, 2024
| stmdev_ctx_t *ctx = (stmdev_ctx_t *)&cfg->ctx; | ||
| lis2dux12_md_t mode = {.odr = odr}; | ||
|
|
||
| data->odr = odr; |
There was a problem hiding this comment.
Calling lis2dux12_set_range() includes odr when calling lis2dux12_mode_set(), but lis2dux12_set_odr() does not consider fs (thus setting it to zero).
Suggestion:
lis2dux12_md_t mode = {.odr = odr .fs = data->range};EDIT: Not blocking this PR as it's not the issue being fixed. Can be followed on a separate one
There was a problem hiding this comment.
@ubieda Good advise! I'm doing it as a separate PR. Thanks for catching it.
teburd
approved these changes
Jul 24, 2024
No need Maureen. The lis2dux12 driver has been introduced in a846b81, after v3.6.0 has been released. So, it's not present there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return to sensor_api i/f the temperature in Celsius instead of the register raw value in LSB.
Fixes #75686
Moreover, it fixes few other issues discovered while debugging.