[Backport v3.7-branch] shell: shell_help: fix terminal offset of subcommands' help text #77643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `SHELL_CMD_ARG_REGISTER` for the main cmd to state the required number of arguments, this helps to remove the runtime check from the command, and also print the help message to the terminal when the argument count is unexpected. - Some changes to the help text that hopefully makes the mandatory and optional arguments more obvious to the user Signed-off-by: Yong Cong Sin <[email protected]> Signed-off-by: Yong Cong Sin <[email protected]> (cherry picked from commit 276ccd0)
The terminal offset for subcommands' help text isn't computed correctly, fix it. Signed-off-by: Yong Cong Sin <[email protected]> Signed-off-by: Yong Cong Sin <[email protected]> (cherry picked from commit fd1be98)
zephyrbot
added
Backport
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
jakub-uC
approved these changes
Oct 27, 2024
|
@ycsin This needs a bug report in order to get backported. |
ycsin
approved these changes
Nov 4, 2024
Totally forgot about this backport, added issue, thanks |
aescolar
approved these changes
Nov 4, 2024
henrikbrixandersen
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fd1be98~2..fd1be98 from #77464.
Fixes #80818