Skip to content

drivers: flash: spi_nor: Set 4-byte addr mode via Bank Addr Reg #77845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

drivers: flash: spi_nor: Set 4-byte addr mode via Bank Addr Reg #77845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions drivers/flash/spi_nor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,26 +1094,40 @@ static int spi_nor_set_address_mode(const struct device *dev,

/* This currently only supports command 0xB7 (Enter 4-Byte
* Address Mode), with or without preceding WREN.
* Or when BIT(3) is set where the 4-byte address mode can be entered
* by setting BIT(7) in a register via a 0x17 write
* instruction. See JEDEC 216F 16th DWORD.
*/
if ((enter_4byte_addr & 0x03) == 0) {
if ((enter_4byte_addr & 0x0b) == 0) {
return -ENOTSUP;
}

acquire_device(dev);

if ((enter_4byte_addr & 0x08) != 0) {
/* Enter 4-byte address mode by setting BIT(7) in a register
* via a 0x17 write instruction.
*/
uint8_t sr = BIT(7);
Copy link
Contributor

@de-nordic de-nordic Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment here on JEDEC 216F description of Enter 4-Byte Addressing and just use hardcoded 0x17 with explanation in comment.


ret = spi_nor_access(dev, 0x17, NOR_ACCESS_WRITE, 0, &sr, sizeof(sr));
goto done;
}

if ((enter_4byte_addr & 0x02) != 0) {
/* Enter after WREN. */
ret = spi_nor_cmd_write(dev, SPI_NOR_CMD_WREN);
}

if (ret == 0) {
ret = spi_nor_cmd_write(dev, SPI_NOR_CMD_4BA);
}

if (ret == 0) {
struct spi_nor_data *data = dev->data;
done:
if (ret == 0) {
struct spi_nor_data *data = dev->data;

data->flag_access_32bit = true;
}
data->flag_access_32bit = true;
}

release_device(dev);
Expand Down
Loading