Skip to content

Conversation

@sumitbatra-nxp
Copy link
Contributor

  1. Support both icm42688 and icm42686 through the same driver
  2. Add support for setting Anti Alias Filter and some additional features for Accelerometer and Gyroscope
  3. Tune icm4268x sensors for VMURT1170 for NXP's Mobile Robotics products

This PR has same commits as - PR #75187
PR #75187 got closed since nxp-zephyr repo had to be deleted.
Requesting the stakeholders to kindly continue your review here

sumitbatra-nxp and others added 2 commits September 3, 2024 14:06
Support both icm42686 and icm42688 through the same driver

Co-authored-by: Mayank Mahajan <[email protected]>
Signed-off-by: Sumit Batra <[email protected]>
Add Filters for Accelerometer and Gyroscope and other dt options

Signed-off-by: Sumit Batra <[email protected]>
@sumitbatra-nxp
Copy link
Contributor Author

Hi @teburd @decsny .. Kindly continue the review of #75187 here

Populate vmu_rt1170 board dts file with default settings for icm42688
and icm42686

Co-authored-by: Mayank Mahajan <[email protected]>
Signed-off-by: Sumit Batra <[email protected]>
@decsny decsny requested review from bperseghetti and decsny and removed request for EmilioCBen and decsny September 5, 2024 15:01
@decsny
Copy link
Member

decsny commented Sep 13, 2024

@MaureenHelm can you help review this PR ?

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Nov 13, 2024
@teburd teburd removed the Stale label Nov 13, 2024
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jan 13, 2025
@github-actions github-actions bot closed this Jan 28, 2025
@teburd teburd removed the Stale label Jan 28, 2025
@teburd teburd reopened this Jan 28, 2025
@teburd
Copy link
Contributor

teburd commented Jan 28, 2025

If CI is passing I will review this tomorrow, if not I will review once CI passes

@MaureenHelm
Copy link
Member

@afontaine-invn please take a look

@bperseghetti
Copy link
Member

bperseghetti commented Jan 28, 2025

@afontaine-invn please take a look

@MaureenHelm I think our internal plan was to have @sumitbatra-nxp rebase on the changes we made in #76861

As the current drive doesn't properly work, I will try to rework that PR so the tests are board specific. I also believe that you have that board as well.

@sumitbatra-nxp
Copy link
Contributor Author

@afontaine-invn please take a look

@MaureenHelm I think our internal plan was to have @sumitbatra-nxp rebase on the changes we made in #76861

As the current drive doesn't properly work, I will try to rework that PR so the tests are board specific. I also believe that you have that board as well.

@bperseghetti I am panning to work on this PR on Jan 31st.. Please let me know if it is more urgent than that.

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Mar 31, 2025
@github-actions github-actions bot closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants