llext: add tests for init arrays #77941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load the .preinit_array, .init_array and .fini_array sections in ELF files. These sections are arrays of function pointers that are filled by the compiler with the addresses of functions that need to be called at startup or termination by the loader, such as C++ constructors and destructors. Signed-off-by: Luca Burelli <[email protected]>
llext_bringup() and llext_teardown() are intended to be used to call the extension's own initialization and cleanup functions, respectively. They are meant to be called by the developer after loading an extension and before unloading it. The list of function pointers to be called is obtained via the new llext_get_fn_table() syscall, so that they are compatible with user mode. llext_bootstrap() is intended to be used as the entry point for a thread created to run an extension, in either user or kernel contexts. It will call the extension's own initialization functions and then an additional entry point in the same context (if desired). The same function can also be called directly in the main thread, if only initialization is required. Signed-off-by: Luca Burelli <[email protected]>
Add documentation for the new LLEXT APIs that allow to call the initialization and cleanup functions of an extension. Signed-off-by: Luca Burelli <[email protected]>
This patch refactors the macro for test case definition to simplify the generic case. By using variable macro arguments and default-0 fields, the most common case does not require arguments at all and tests that have special requirements can be defined with only the necessary fields. Signed-off-by: Luca Burelli <[email protected]>
pillo79
force-pushed
the
pr-test-init-arrays
branch
from
ffd5cc4 to
dc41a6e
Compare
lyakh
reviewed
Sep 6, 2024
There was a problem hiding this comment.
No special reason. We also need to be 64-bit inclusive now 😄 so I'll switch.
This commit renames the perm_setup callback to test_setup and provides the extension as an additional parameter. It also adds a test_cleanup callback that is called after each test completes. Setup and cleanup functions are now called regardless of whether CONFIG_USERSPACE is enabled or not. Signed-off-by: Luca Burelli <[email protected]>
Add a test to check the proper support of ELF init arrays, using the new llext_bootstrap function in place of llext_entry in the LLEXT test suite. Signed-off-by: Luca Burelli <[email protected]>
teburd
previously approved these changes
Sep 6, 2024
pillo79
force-pushed
the
pr-test-init-arrays
branch
from
dc41a6e to
ad53931
Compare
teburd
approved these changes
Sep 6, 2024
mathieuchopstm
approved these changes
Sep 10, 2024
|
|
||
| #include "llext_priv.h" | ||
|
|
||
| ssize_t z_impl_llext_get_fn_table(struct llext *ext, bool is_init, void *buf, size_t buf_size) |
There was a problem hiding this comment.
Nit: enum fn_table_type table_type instead of bool is_init would be more future-proof, although I don't know if there are other tables we might have to make available.
Comment on lines
+63
to
+64
| LOG_ERR("init function %i (%p) outside text region", | ||
| i, fn_ptrs[i]); |
There was a problem hiding this comment.
Nit: init function in string is not necessarily appropriate
Suggested change
| LOG_ERR("init function %i (%p) outside text region", | |
| i, fn_ptrs[i]); | |
| LOG_ERR("%s function %i (%p) outside text region", | |
| is_init ? "init" : "fini", i, fn_ptrs[i]); |
Comment on lines
+305
to
+306
| /* These regions are not extendable and must be | ||
| * referenced at most once in the ELF file. |
There was a problem hiding this comment.
Nit: should refer to sections rather than regions
Proposal:
Suggested change
| /* These regions are not extendable and must be | |
| * referenced at most once in the ELF file. | |
| /* Each of these sections can only be present at most | |
| * once in an ELF file. Finding a second one indicates | |
| * the ELF is malformed and should be rejected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #77641 (first 3 commits) and adds the test suite for that feature. Will be set as ready as soon as the parent PR is merged.
LLEXT test case definition has been improved to use struct syntax, so that tests can easily define many custom features. New
test_cleanupcallback has been added to check the proper execution of the routine linked in.fini_array.