-
Notifications
You must be signed in to change notification settings - Fork 8.3k
drivers: video: gc2145: fixes compatible prefix of gc2145 #78431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong? Why wasn't the existing galaxycore vendor picked in the first place? The proper fix would be to update the binding/driver to use that instead of gc
|
Oh, that is true, I will change this PR, I did not realize there is a prefix yet, thanks @kartben |
of the compatible driver, use galaxycore instead of gc. Signed-off-by: Felipe Neves <[email protected]>
bcf40be to
cd17ad2
Compare
|
Hi Folks, can we merge this? I would like to have this one merged beefore the camera support from Nicla Vision (or other use case for GC2145) comes in. Thank you :) |
|
@uLipe Please do not self-assign PRs, the zephyr bot usually does that, you should only be assigned if you are the maintainer of the area being changed. |
It will get merged in the next merge batch. It hadn't been in review for 48 business hours until very recently, so that's why it hasn't been merged yet :) |
This change is required to fix dts error of unknown vendor when parsing the compatible string when instancing gc2145.
Although it builds applications correctly, this error makes the ci to fail if some board instance this sensor on its dts, this is caused because it was not using the already existing prefix galaxycore, it was merged using gc prefix instead.