Skip to content

Conversation

@rettichschnidi
Copy link
Contributor

This fixes the following warnings:

unit address and first address in 'reg' (0xa080000) don't match for
/mram@a080400

This fixes the following warnings:

> unit address and first address in 'reg' (0xa080000) don't match for
> /mram@a080400

Signed-off-by: Reto Schneider <[email protected]>
@rettichschnidi rettichschnidi marked this pull request as ready for review September 15, 2024 20:10
@zephyrbot zephyrbot added size: XS A PR changing only a single line of code platform: ARM Arm Limited labels Sep 15, 2024
@zephyrbot zephyrbot requested a review from ithinuel September 15, 2024 20:11
@fabiobaltieri fabiobaltieri added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Sep 20, 2024
@ithinuel
Copy link
Contributor

Do you have any reason to pick one of the value over the other one?
I tried to find some data to coroborate. If anything TF-M’s layout would go for 0xA080000 but the extra kilobyte (0x400) could be to accomodate an MCUBoot header.
I’m not familiar enough to confirm this is correct either way.

@rettichschnidi
Copy link
Contributor Author

Do you have any reason to pick one of the value over the other one?

My understanding is that the reg value is what actually ends up in the build. Therefore, I adapted the "cosmetic" value to match it. The result is that the warning is gone, while the resulting binary is not changed at all.

@rettichschnidi
Copy link
Contributor Author

Not a proof, but my other 10+ PRs using the same kind of fix have been accepted: #78253

@henrikbrixandersen
Copy link
Member

Do you have any reason to pick one of the value over the other one?

My understanding is that the reg value is what actually ends up in the build. Therefore, I adapted the "cosmetic" value to match it. The result is that the warning is gone, while the resulting binary is not changed at all.

Correct.

@fabiobaltieri fabiobaltieri merged commit 58d9e3d into zephyrproject-rtos:main Sep 27, 2024
@rettichschnidi rettichschnidi deleted the gardena/rs/upstream/fix-address-mismatch-v2m_musca_s1 branch April 11, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: ARM Arm Limited size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants