-
Notifications
You must be signed in to change notification settings - Fork 8.3k
edtlib: Apply Werror to address mismatches #78253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edtlib: Apply Werror to address mismatches #78253
Conversation
896f908 to
58d0feb
Compare
e571ab4 to
f5be105
Compare
f5be105 to
307b662
Compare
|
@rettichschnidi can you rebase so that we see where CI is that on this one? |
307b662 to
c45fdbf
Compare
Just done. Will also run |
|
@kartben Just updated the initial issue description. |
|
@rettichschnidi are we now out of blockers, potentially? :) |
|
No objections to merging this once CI is green |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
@rettichschnidi wanna try to rebase to kick CI again? Would have done it myself but you up re not allowing edits to your PR branches :) |
c45fdbf to
11ef4a2
Compare
Just rebased. Would be willing to give you access, but I think it is not possible when the fork is owned by another organization. |
|
Just updated the issue with the result of my latest (local) run. Will create PRs to fix up the findings. But if anyone else wants to to do that, feel free to do so. :) |
When running gen_defines.py with --edtlib-Werror, this change causes address mismatches to be treated as errors. Signed-off-by: Reto Schneider <[email protected]>
11ef4a2 to
a464414
Compare
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
Will not have time for this for the foreseeable future. Closing. |
Problem
When running gen_defines.py with --edtlib-Werror, this change causes address mismatches to be treated as errors.
For now, this change will fail in CI due to preexisting, so far not discovered/cleaned up issues.
This PR can (should) be merged only once the following command does not yield any issue anymore:
twister --cmake-onlyResults
v4.1.0-2236-g11ef4a293c4(twister --cmake-only --runtime-artifact-cleanup all):v4.0.0-769-gb06bf51459e(twister --cmake-only --runtime-artifact-cleanup all):v3.7.0-5004-ga2f2dc9ad11:The following issues have been identified as blockers for this PR:
If anyone knows another way to resolve/work around those issues, please let me know.
Already resolved blockers: