Bluetooth: Mesh: Introduce separate workq for ADV EXT #78914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth
area: Bluetooth Mesh
platform: nRF BSIM
zephyrbot
requested review from
Andrewpini,
HaavardRei,
PavelVPV,
aescolar,
akredalen,
alxelax,
jhedberg and
omkar3141
LingaoM
force-pushed
the
enhance_mesh_workq
branch
3 times, most recently
from
163bdac to
9b92a23
Compare
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
LingaoM
force-pushed
the
enhance_mesh_workq
branch
2 times, most recently
from
59c7f00 to
2aa86bd
Compare
jhedberg
reviewed
Sep 25, 2024
LingaoM
force-pushed
the
enhance_mesh_workq
branch
from
2aa86bd to
5a157fa
Compare
jhedberg
previously approved these changes
Sep 25, 2024
LingaoM
force-pushed
the
enhance_mesh_workq
branch
from
5a157fa to
8575a76
Compare
jhedberg
previously approved these changes
Sep 26, 2024
Contributor
LingaoM
force-pushed
the
enhance_mesh_workq
branch
from
a18a59c to
0430c6d
Compare
PavelVPV
previously approved these changes
Oct 31, 2024
alxelax
previously approved these changes
Oct 31, 2024
tejlmand
requested changes
Nov 1, 2024
Contributor
tejlmand
left a comment
tejlmand
left a comment
There was a problem hiding this comment.
Generally looks good, only some minor nits.
subsys/bluetooth/mesh/Kconfig
Outdated
Contributor
There was a problem hiding this comment.
Consider reducing this title to:
Suggested change
| bool "Send messages from in the mesh-specific workqueue" | |
| bool "Mesh-specific workqueue" |
This will thing look neater in menuconfig, which is where the title has a role.
Without change:
With change:
subsys/bluetooth/mesh/Kconfig
Outdated
Contributor
There was a problem hiding this comment.
It's confusing to have config options together with choice entries like this, as it makes it a harder for the developer to identify the specific choice entries.
Also note, that this construct is only possible because the config types are not bools.
Please move the int entries outside the choice.
subsys/bluetooth/mesh/Kconfig
Outdated
Contributor
There was a problem hiding this comment.
Related to other comment, consider reducing this title to:
Suggested change
| bool "Send messages from the system workqueue" | |
| bool "System workqueue" |
this PR is to make the host always send packets. Signed-off-by: Lingao Meng <[email protected]>
LingaoM
force-pushed
the
enhance_mesh_workq
branch
from
0430c6d to
84220f2
Compare
alxelax
approved these changes
Nov 1, 2024
tejlmand
approved these changes
Nov 4, 2024
PavelVPV
approved these changes
Nov 4, 2024
PavelVPV
added a commit
to PavelVPV/zephyr
that referenced
this pull request
Nov 25, 2024
Fix extracting role from k_work. Hot fix for zephyrproject-rtos#78914 Signed-off-by: Pavel Vasilyev <[email protected]>
nashif
pushed a commit
that referenced
this pull request
Nov 28, 2024
Fix extracting role from k_work. Hot fix for #78914 Signed-off-by: Pavel Vasilyev <[email protected]>
zephyrbot
pushed a commit
that referenced
this pull request
Nov 28, 2024
Fix extracting role from k_work. Hot fix for #78914 Signed-off-by: Pavel Vasilyev <[email protected]> (cherry picked from commit f5409bd)
dkalowsk
pushed a commit
that referenced
this pull request
Dec 6, 2024
Fix extracting role from k_work. Hot fix for #78914 Signed-off-by: Pavel Vasilyev <[email protected]> (cherry picked from commit f5409bd)
nordic-krch
pushed a commit
to nordic-krch/zephyr
that referenced
this pull request
Dec 11, 2024
…_work Fix extracting role from k_work. Hot fix for zephyrproject-rtos#78914 Signed-off-by: Pavel Vasilyev <[email protected]> (cherry picked from commit f5409bd) Signed-off-by: Håvard Reierstad <[email protected]> (cherry picked from commit 52c7aa82212fb9280bd733145262c0d32d8d5b27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an independent Mesh workq will better ensure the reliability of mesh message sending, including when sysworkq is blocked elsewhere, also to make the host always send packets