-
Notifications
You must be signed in to change notification settings - Fork 8.3k
boards: beagle: beaglev_fire: Specify the different targets supported for beaglev_fire and fix build instructions #79511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @Ayush1325, thanks for the PR. is it not overkill having 3 seperate docs for the one board? would it not be better to describe the variants in a single doc? |
Well, for a board like beagleplay, I would prefer to have separate docs for each target. Having separate docs allows for providing specific instructions for building, debugging, peripheral numbering, etc, more clearly. But I am not familiar enough with the difference between the capabilities of e15 and u54 to say if they are different enough to warrant separate pages. I am just trying to facilitate the future target specific doc improvement. I would be okay with whatever upstream Zephyr prefers to be honest. It's just important to have docs that can clearly explain that 3 different targets can be used for beaglev-fire. |
aac51b3 to
c907814
Compare
|
@con-pax I now have a single page for beaglev-fire and just added the targets and fixed the build example. |
con-pax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@gbcstott, this is the fix to the documentation per your issue. Can you please review. |
d989eb9 to
4ce16b3
Compare
|
I looked at the doc preview for this change and it looks great. Thanks. |
842ef61 to
082b83c
Compare
- Fix the board name in build example - Add link to datasheet - Specify the different targets supported for beaglev_fire Signed-off-by: Ayush Singh <[email protected]>
082b83c to
345d8c1
Compare
|
@Ayush1325 can you describe the process of loading "hello world" without using OpenOCD? Is there a way to enable |
I do not have much idea since I do not have a beaglev-fire. But I have posted the link to this on Discord, so hopefully, someone can comment. |
|
Closing in favor of #80656 |
Uh oh!
There was an error while loading. Please reload this page.