Skip to content

TI MSPM0 Support #79673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

TI MSPM0 Support #79673

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4227dad
west: west.yml pointed to in-flight PR for MSPM0 support
JFMSP Dec 3, 2024
24e8378
soc: added initial SOC support for TI MSPM0
JFMSP Jan 16, 2025
e8f2210
dts: add MSPM0 family to the devicetree
JFMSP Mar 22, 2024
48030a7
dts: added pinctrl data for MSPM0
JFMSP Dec 3, 2024
4c0e81d
drivers: added clock control driver for MSPM0
JFMSP Dec 3, 2024
d390b17
drivers: added pinctrl driver for MSPM0
JFMSP Mar 22, 2024
cf5480f
drivers: added gpio driver for MSPM0 family
JFMSP Mar 22, 2024
8d0d1fa
drivers: added serial driver for MSPM0
JFMSP Mar 19, 2024
d0c9952
boards: added TI LP_MSPM0G3507 board
JFMSP Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dts/arm/ti/mspm0g1x0x_g3x0x/mspm0g110x-pinctrl.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include <ti/mspm0g1x0x_g3x0x/mspm0g1x0x_g3x0x-pinctrl.dtsi>
1 change: 1 addition & 0 deletions dts/arm/ti/mspm0g1x0x_g3x0x/mspm0g150x-pinctrl.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include <ti/mspm0g1x0x_g3x0x/mspm0g1x0x_g3x0x-pinctrl.dtsi>
142 changes: 142 additions & 0 deletions dts/arm/ti/mspm0g1x0x_g3x0x/mspm0g1x0x_g3x0x-pinctrl.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,142 @@
#include <dt-bindings/pinctrl/mspm0-pinctrl.h>

&pinctrl {

Copy link
Member

@parthitce parthitce Nov 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea is to add all the pin functions? or the ones added in this PR? It's mixed now. Not all is added and also includes pin function for the ones which are not supported in this PR

Copy link
Contributor

@nordicjm nordicjm Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor

@nordicjm nordicjm Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not addressed

/omit-if-no-ref/ i2c0_scl_pa1: i2c0_scl_pa1 {
pinmux = <MSP_PINMUX(2,MSPM0_PIN_FUNCTION_3)>;
Copy link
Member

@parthitce parthitce Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, spacing and the same across this file
pinmux = <MSP_PINMUX(2, MSPM0_PIN_FUNCTION_3)>;

input-enable;
drive-open-drain;
};

/omit-if-no-ref/ i2c0_sda_pa0: i2c0_sda_pa0 {
pinmux = <MSP_PINMUX(1,MSPM0_PIN_FUNCTION_3)>;
input-enable;
Copy link
Member

@parthitce parthitce Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bias-pull-up; is missing

drive-open-drain;
};

/omit-if-no-ref/ i2c1_sda_pa10: i2c1_sda_pa10 {
Copy link
Member

@parthitce parthitce Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am not sure why _pull_down/up is missing here. Is it because the pin is High-Drive? Otherwise we don't need to keep a separate suffix for pull_up for all the I2C.

pinmux = <MSP_PINMUX(21,MSPM0_PIN_FUNCTION_8)>;
input-enable;
drive-open-drain;
};

/omit-if-no-ref/ i2c1_scl_pa11: i2c1_scl_pa11 {
pinmux = <MSP_PINMUX(22,MSPM0_PIN_FUNCTION_8)>;
input-enable;
drive-open-drain;
};

/omit-if-no-ref/ i2c1_scl_pb2: i2c1_scl_pb2 {
pinmux = <MSP_PINMUX(15,MSPM0_PIN_FUNCTION_4)>;
input-enable;
drive-open-drain;
};

/omit-if-no-ref/ i2c1_sda_pb3: i2c1_sda_pb3 {
pinmux = <MSP_PINMUX(16,MSPM0_PIN_FUNCTION_4)>;
input-enable;
drive-open-drain;
};

/omit-if-no-ref/ i2c1_sda_pa16: i2c1_sda_pa16 {
pinmux = <MSP_PINMUX(38,MSPM0_PIN_FUNCTION_4)>;
input-enable;
drive-open-drain;
};

/omit-if-no-ref/ i2c1_scl_pa17: i2c1_scl_pa17 {
pinmux = <MSP_PINMUX(39,MSPM0_PIN_FUNCTION_4)>;
input-enable;
drive-open-drain;
};

/omit-if-no-ref/ i2c1_scl_pa29: i2c1_scl_pa29 {
pinmux = <MSP_PINMUX(4,MSPM0_PIN_FUNCTION_2)>;
input-enable;
drive-open-drain;
};

/omit-if-no-ref/ i2c1_sda_pa30: i2c1_sda_pa30 {
pinmux = <MSP_PINMUX(5,MSPM0_PIN_FUNCTION_2)>;
input-enable;
drive-open-drain;
};

/omit-if-no-ref/ i2c0_sda_pa28: i2c0_sda_pa28 {
pinmux = <MSP_PINMUX(3,MSPM0_PIN_FUNCTION_3)>;
input-enable;
drive-open-drain;
};

/omit-if-no-ref/ i2c0_scl_pa31: i2c0_scl_pa31 {
pinmux = <MSP_PINMUX(6,MSPM0_PIN_FUNCTION_3)>;
input-enable;
drive-open-drain;
};

/omit-if-no-ref/ uart0_tx_pa10: uart0_tx_pa10 {
pinmux = <MSP_PINMUX(21,MSPM0_PIN_FUNCTION_2)>;
drive-strength = <20>;
};

/omit-if-no-ref/ uart0_rx_pa11: uart0_rx_pa11 {
pinmux = <MSP_PINMUX(22,MSPM0_PIN_FUNCTION_2)>;
drive-strength = <20>;
input-enable;
};

/omit-if-no-ref/ uart0_rts_pa8: uart0_rts_pa8 {
pinmux = <MSP_PINMUX(19,MSPM0_PIN_FUNCTION_4)>;
};

/omit-if-no-ref/ uart0_cts_pb19: uart0_cts_pb19 {
pinmux = <MSP_PINMUX(19,MSPM0_PIN_FUNCTION_5)>;
input-enable;
};

/omit-if-no-ref/ spi1_sclk_pb9: spi1_sclk_pb9 {
pinmux = <MSP_PINMUX(26,MSPM0_PIN_FUNCTION_3)>;
};

/omit-if-no-ref/ spi1_pico_pb8: spi1_pico_pb8 {
pinmux = <MSP_PINMUX(25,MSPM0_PIN_FUNCTION_3)>;
};

/omit-if-no-ref/ spi1_poci_pb7: spi1_poci_pb7 {
pinmux = <MSP_PINMUX(24,MSPM0_PIN_FUNCTION_3)>;
input-enable;
};

/omit-if-no-ref/ spi1_cs0_pb6: spi1_cs0_pb6 {
pinmux = <MSP_PINMUX(23,MSPM0_PIN_FUNCTION_3)>;
};

/omit-if-no-ref/ spi1_cs1_pb17: spi1_cs1_pb17 {
pinmux = <MSP_PINMUX(43,MSPM0_PIN_FUNCTION_4)>;
};

/omit-if-no-ref/ adc0_pa27: adc0_pa27 {
pinmux = <MSP_PINMUX(60,MSPM0_PIN_FUNCTION_ANALOG)>;
};

/omit-if-no-ref/ adc0_pa26: adc0_pa26 {
pinmux = <MSP_PINMUX(59,MSPM0_PIN_FUNCTION_ANALOG)>;
};

/omit-if-no-ref/ adc0_pa25: adc0_pa25 {
pinmux = <MSP_PINMUX(55,MSPM0_PIN_FUNCTION_ANALOG)>;
};

/omit-if-no-ref/ adc0_pb24: adc0_pb24 {
pinmux = <MSP_PINMUX(52,MSPM0_PIN_FUNCTION_ANALOG)>;
};

/omit-if-no-ref/ adc0_pb25: adc0_pb25 {
pinmux = <MSP_PINMUX(56,MSPM0_PIN_FUNCTION_ANALOG)>;
};

/omit-if-no-ref/ adc1_pb19: adc1_pb19 {
pinmux = <MSP_PINMUX(45,MSPM0_PIN_FUNCTION_ANALOG)>;
};

Copy link
Contributor

@nordicjm nordicjm Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor

@nordicjm nordicjm Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not addressed

};
5 changes: 5 additions & 0 deletions dts/arm/ti/mspm0g1x0x_g3x0x/mspm0g1x0x_g3x0x.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
compatible = "ti,mspm0-gpio";
reg = <0x400a0000 0x2000>;
interrupts = <1 0>;
Copy link
Member

@parthitce parthitce Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the interrupt parent is nvic? interrupt-parent = <&nvic>; ?

interrupt-parent = <&nvic>;
status = "disabled";
gpio-controller;
#gpio-cells = <2>;
Expand All @@ -85,6 +86,7 @@
compatible = "ti,mspm0-gpio";
reg = <0x400a2000 0x2000>;
interrupts = <1 0>;
interrupt-parent = <&nvic>;
status = "disabled";
gpio-controller;
#gpio-cells = <2>;
Expand All @@ -95,6 +97,7 @@
compatible = "ti,mspm0-uart";
reg = <0x40108000 0x2000>;
interrupts = <15 0>;
interrupt-parent = <&nvic>;
current-speed = <115200>;
clocks = <&clkmux MSPM0_CLOCK_BUS_ULPCLK>;
status = "disabled";
Expand All @@ -104,6 +107,7 @@
compatible = "ti,mspm0-uart";
reg = <0x40100000 0x2000>;
interrupts = <13 0>;
interrupt-parent = <&nvic>;
current-speed = <115200>;
clocks = <&clkmux MSPM0_CLOCK_BUS_ULPCLK>;
status = "disabled";
Expand All @@ -113,6 +117,7 @@
compatible = "ti,mspm0-uart";
reg = <0x40102000 0x2000>;
interrupts = <14 0>;
interrupt-parent = <&nvic>;
current-speed = <115200>;
clocks = <&clkmux MSPM0_CLOCK_BUS_ULPCLK>;
status = "disabled";
Expand Down
2 changes: 2 additions & 0 deletions dts/arm/ti/mspm0g1x0x_g3x0x/mspm0g310x-pinctrl.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#include <ti/mspm0g1x0x_g3x0x/mspm0g1x0x_g3x0x-pinctrl.dtsi>
#include <ti/mspm0g1x0x_g3x0x/mspm0g3xxx-pinctrl.dtsi>
2 changes: 2 additions & 0 deletions dts/arm/ti/mspm0g1x0x_g3x0x/mspm0g350x-pinctrl.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#include <ti/mspm0g1x0x_g3x0x/mspm0g1x0x_g3x0x-pinctrl.dtsi>
#include <ti/mspm0g1x0x_g3x0x/mspm0g3xxx-pinctrl.dtsi>
14 changes: 14 additions & 0 deletions dts/arm/ti/mspm0g1x0x_g3x0x/mspm0g3xxx-pinctrl.dtsi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#include <dt-bindings/pinctrl/mspm0-pinctrl.h>

&pinctrl {

Copy link
Contributor

@nordicjm nordicjm Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

can0_rx_pa13: can0_rx_pa13 {
pinmux = <MSP_PINMUX(35,MSPM0_PIN_FUNCTION_6)>;
input-enable;
};

can0_tx_pa12: can0_tx_pa12 {
pinmux = <MSP_PINMUX(34,MSPM0_PIN_FUNCTION_6)>;
};

Comment on lines +4 to +13
Copy link
Contributor

@nordicjm nordicjm Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

};