i.MX RT700 DSP support #79954

iuliana-prodan · 2024-10-16T23:24:34Z

The i.MX RT700 has a Compute Subsystem which includes a primary ARM Cortex-M33 running at 325 MHz and Cadence Tensilica HiFi 4 DSP.
It also features an ultra-low power Sense Subsystem which includes a second ARM Cortex-M33 and Cadence Tensilica HiFi 1 DSP.

This pull request adds the soc and board support for the two HiFi cores.

zephyrbot · 2024-10-16T23:25:30Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_xtensa	zephyrproject-rtos/hal_xtensa@`baa56aa`	zephyrproject-rtos/hal_xtensa@`b38620c`	zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

soc/nxp/imxrt/imxrt7xx/Kconfig.defconfig

iuliana-prodan · 2024-10-21T14:10:47Z

The twister tests are failing because the CI is using zephyr_sdk 0.16.8 which doesn't include the hifi1 and hifi4 toolchain for imxrt700.

Configuration saved to '/__w/zephyr/zephyr/twister-out/mimxrt700_evk_mimxrt798s_hifi1/samples/kernel/condition_variables/simple/sample.kernel.cond_var.simple/zephyr/.config'
Kconfig header saved to '/__w/zephyr/zephyr/twister-out/mimxrt700_evk_mimxrt798s_hifi1/samples/kernel/condition_variables/simple/sample.kernel.cond_var.simple/zephyr/include/generated/zephyr/autoconf.h'
CMake Error at /__w/zephyr/zephyr/cmake/compiler/gcc/target.cmake:12 (message):
  C compiler
  /opt/toolchains/zephyr-sdk-0.16.8/xtensa-nxp_rt700_hifi1_zephyr-elf/bin/xtensa-nxp_rt700_hifi1_zephyr-elf-gcc
  not found - Please check your toolchain installation

Locally I used zephyr-sdk-0.16.9-rc2 which had the 2 toolchain.

I see now that 0.17.0 was released.
@stephanosio when will the new toolchain be included in the CI?
Can I do the update?

boards/nxp/mimxrt700_evk/board.cmake

iuliana-prodan · 2025-02-24T16:16:32Z

@iuliana-prodan the RT700 HAL PR merged. Can you update this PR to move the NXP HAL SHA to the tip and then resolve the merge conflicts? We can get this ready to merge quickly after the upstream v4.1 release

Yes, I have this on my list :)
I'll do it this week!

iuliana-prodan · 2025-03-04T17:19:58Z

Changes since previous version:

rebase and resolve conflicts with the M33 Core 0 and Core1 support for i.MXRT700;
update west.yml only with commit id for Xtensa HAL (NXP hal was merged and updated in west.yml);

west.yml

nordicjm · 2025-03-05T07:10:04Z

soc/nxp/imxrt/imxrt7xx/Kconfig.defconfig

+config LOG
+	default n


log defaults to n anyway?

soc/nxp/imxrt/imxrt7xx/Kconfig.defconfig

nordicjm · 2025-03-05T07:13:52Z

soc/nxp/imxrt/imxrt7xx/hifi4/linker.ld

+
+MEMORY
+{
+  vector_reset_text :


zephyr uses tab indents for code

Most linker script files use spaces, with only a few (such as mips) using tabs. Therefore, I’ve kept the linker scripts for hifi1 and hifi4 formatted with spaces.
If you strongly prefer tabs, I can update them, but in my opinion, this approach aligns with Zephyr’s current formatting.

Seems there is a mix of space and tabs in different files, will allow

nordicjm · 2025-03-05T07:14:35Z

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_hifi4_defconfig

+CONFIG_GEN_ISR_TABLES=y
+CONFIG_GEN_IRQ_VECTOR_TABLE=n
+CONFIG_XTENSA_SMALL_VECTOR_TABLE_ENTRY=y
+CONFIG_NXP_IMXRT_BOOT_HEADER=n


why are these not at soc level?

moved them to soc (in Kconfig.defconfig) but some are with default n since they are defined with default y - see CONFIG_GEN_IRQ_VECTOR_TABLE and CONFIG_NXP_IMXRT_BOOT_HEADER

nordicjm · 2025-03-05T07:15:52Z

soc/nxp/imxrt/imxrt7xx/Kconfig.defconfig

+config SYS_CLOCK_HW_CYCLES_PER_SEC
+	default 325000000


why doesn't this come from a dts property?

nordicjm · 2025-03-05T07:16:11Z

soc/nxp/imxrt/imxrt7xx/hifi1/linker.ld

+
+MEMORY
+{
+  vector_reset_text :


nordicjm · 2025-03-05T07:16:25Z

boards/nxp/mimxrt700_evk/mimxrt700_evk_mimxrt798s_hifi1_defconfig

+CONFIG_GEN_ISR_TABLES=y
+CONFIG_GEN_IRQ_VECTOR_TABLE=n
+CONFIG_XTENSA_SMALL_VECTOR_TABLE_ENTRY=y
+CONFIG_NXP_IMXRT_BOOT_HEADER=n


nordicjm · 2025-03-05T07:17:04Z

boards/nxp/mimxrt700_evk/doc/index.rst

+.. code-block:: shell
+
+   $ west build -b mimxrt700_evk/mimxrt798s/hifi1 samples/hello_world
+


there is a

.. zephyr-app-commands:: :tool: west

for this

nordicjm · 2025-03-05T07:17:13Z

boards/nxp/mimxrt700_evk/doc/index.rst

+
+.. code-block:: shell
+
+   $ west build -b mimxrt700_evk/mimxrt798s/hifi4 samples/hello_world


Update Xtensa hal to support NXP i.MXRT700 DSP cores. Signed-off-by: Iuliana Prodan <[email protected]>

The i.MX RT700 has a compute subsystem which includes a primary ARM Cortex-M33 running at 325 MHz and Cadence Tensilica HiFi4 DSP. Here, we add support for the HiFi4 core. Signed-off-by: Iuliana Prodan <[email protected]>

Add a basic device tree for the HiFi4 DSP from NXP i.MXRT700. Signed-off-by: Iuliana Prodan <[email protected]>

Add board support for the HiFi4 DSP core from NXP i.MXRT700. Signed-off-by: Iuliana Prodan <[email protected]>

The i.MX RT700 has an ultra-low power Sense Subsystem which includes an ARM Cortex-M33 and Cadence Tensilica HiFi 1 DSP. Here, we add support for the HiFi1 core. Signed-off-by: Iuliana Prodan <[email protected]>

Add a basic device tree for the HiFi1 DSP from NXP i.MXRT700. Signed-off-by: Iuliana Prodan <[email protected]>

Add board support for the HiFi1 DSP core from NXP i.MXRT700. Signed-off-by: Iuliana Prodan <[email protected]>

Add documentation for the two HiFi1 and HiFi4 DSP cores from i.MXRT700. Signed-off-by: Iuliana Prodan <[email protected]>

iuliana-prodan · 2025-03-06T11:11:33Z

@nordicjm Thanks for reviewing.
I've resolved all you comments, except this

dcpleung · 2025-03-07T17:20:04Z

Removing the DNM tag since the Zephyr bot tagged it using an old tag.

iuliana-prodan requested a review from dbaluta as a code owner October 16, 2024 23:24

zephyrbot added area: Xtensa Xtensa Architecture platform: NXP NXP labels Oct 16, 2024

zephyrbot requested review from DerekSnell, EmilioCBen, andyross, butok, ceolin, danieldegrasse, dcpleung, decsny, dleach02, mmahadevan108, nashif and yvanderv October 16, 2024 23:25

zephyrbot assigned dcpleung Oct 16, 2024

zephyrbot added manifest manifest-hal_xtensa manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Oct 16, 2024

dcpleung reviewed Oct 16, 2024

View reviewed changes

soc/nxp/imxrt/imxrt7xx/Kconfig.defconfig Outdated Show resolved Hide resolved

iuliana-prodan force-pushed the rt700_dsp_support branch 5 times, most recently from 9f51a11 to 2e37183 Compare October 18, 2024 14:51

dcpleung previously approved these changes Oct 18, 2024

View reviewed changes

danieldegrasse reviewed Oct 21, 2024

View reviewed changes

boards/nxp/mimxrt700_evk/board.cmake Outdated Show resolved Hide resolved

iuliana-prodan dismissed stale reviews from dbaluta and nordicjm via f5d3313 March 4, 2025 16:58

iuliana-prodan force-pushed the rt700_dsp_support branch from 428022c to f5d3313 Compare March 4, 2025 16:58

zephyrbot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Mar 4, 2025

iuliana-prodan force-pushed the rt700_dsp_support branch from f5d3313 to c29c286 Compare March 4, 2025 17:05

dcpleung previously approved these changes Mar 4, 2025

View reviewed changes

iuliana-prodan requested review from dbaluta and nordicjm March 4, 2025 17:34

nordicjm requested changes Mar 5, 2025

View reviewed changes

iuliana-prodan added 7 commits March 6, 2025 11:45

west.yml: Update Xtensa hal

31f2679

Update Xtensa hal to support NXP i.MXRT700 DSP cores. Signed-off-by: Iuliana Prodan <[email protected]>

soc: nxp: imxrt700: Add i.MXRT700 HiFi4 DSP support

162b986

The i.MX RT700 has a compute subsystem which includes a primary ARM Cortex-M33 running at 325 MHz and Cadence Tensilica HiFi4 DSP. Here, we add support for the HiFi4 core. Signed-off-by: Iuliana Prodan <[email protected]>

dts: xtensa: nxp: Add device tree for HiFi4 core from NXP i.MXRT700

9a5854f

Add a basic device tree for the HiFi4 DSP from NXP i.MXRT700. Signed-off-by: Iuliana Prodan <[email protected]>

boards: nxp: imxrt700: Add i.MXRT700 HiFi4 board support

a010677

Add board support for the HiFi4 DSP core from NXP i.MXRT700. Signed-off-by: Iuliana Prodan <[email protected]>

soc: nxp: imxrt700: Add i.MXRT700 HiFi1 DSP support

f78317e

The i.MX RT700 has an ultra-low power Sense Subsystem which includes an ARM Cortex-M33 and Cadence Tensilica HiFi 1 DSP. Here, we add support for the HiFi1 core. Signed-off-by: Iuliana Prodan <[email protected]>

dts: xtensa: nxp: Add device tree for HiFi1 core from NXP i.MXRT700

3b0091d

Add a basic device tree for the HiFi1 DSP from NXP i.MXRT700. Signed-off-by: Iuliana Prodan <[email protected]>

boards: nxp: imxrt700: Add i.MXRT700 HiFi1 board support

601b34c

Add board support for the HiFi1 DSP core from NXP i.MXRT700. Signed-off-by: Iuliana Prodan <[email protected]>

iuliana-prodan dismissed dcpleung’s stale review via f703885 March 6, 2025 09:57

iuliana-prodan force-pushed the rt700_dsp_support branch 2 times, most recently from f703885 to df62609 Compare March 6, 2025 10:03

iuliana-prodan requested a review from nordicjm March 6, 2025 11:05

boards: nxp: imxrt700: Add documentation for i.MXRT700 DSP cores

b9f85bb

Add documentation for the two HiFi1 and HiFi4 DSP cores from i.MXRT700. Signed-off-by: Iuliana Prodan <[email protected]>

iuliana-prodan force-pushed the rt700_dsp_support branch from df62609 to b9f85bb Compare March 6, 2025 11:10

nordicjm approved these changes Mar 7, 2025

View reviewed changes

dcpleung approved these changes Mar 7, 2025

View reviewed changes

dcpleung removed the DNM This PR should not be merged (Do Not Merge) label Mar 7, 2025

carlescufi merged commit e4ccfa3 into zephyrproject-rtos:main Mar 7, 2025
25 of 26 checks passed

		.. code-block:: shell

		$ west build -b mimxrt700_evk/mimxrt798s/hifi1 samples/hello_world

i.MX RT700 DSP support #79954

i.MX RT700 DSP support #79954

Uh oh!

Conversation

iuliana-prodan commented Oct 16, 2024

Uh oh!

zephyrbot commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

iuliana-prodan commented Oct 21, 2024

Uh oh!

Uh oh!

iuliana-prodan commented Feb 24, 2025

Uh oh!

iuliana-prodan commented Mar 4, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iuliana-prodan commented Mar 6, 2025

Uh oh!

dcpleung commented Mar 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

zephyrbot commented Oct 16, 2024 •

edited

Loading