Skip to content

tests: drivers: can: api: fix misunderstood use of ESI flag #80380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024
Merged

tests: drivers: can: api: fix misunderstood use of ESI flag #80380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions tests/drivers/can/api/src/canfd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,22 +257,20 @@ ZTEST(canfd, test_send_fd_dlc_out_of_range)
}

/**
* @brief Test error when CAN FD Error State Indicator (ESI) is send without FD format flag (FDF).
* @brief Test error when CAN FD Error State Indicator (ESI) is set on transmit frame.
*
* CAN FD Error State Indicator (ESI) indicates that the transmitting node is
* in error-passive state. Only valid in combination with CAN_FRAME_FDF.
Copy link
Contributor

@nordic-segl nordic-segl Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied from the CAN API documentation at
https://docs.zephyrproject.org/latest/doxygen/html/group__can__interface.html#ga83f8b7af6eb45e43aaac355de3e69e52
Is it worth to make changes there too?

* CAN FD Error State Indicator (ESI) indicates that the transmitting node is in error-passive
* state, but should never be set explicitly. Setting it is handled in the CAN controller hardware.
*/
ZTEST(canfd, test_send_fd_incorrect_esi)
{
struct can_frame frame = {
.flags = CAN_FRAME_ESI,
.flags = CAN_FRAME_FDF | CAN_FRAME_ESI,
.id = TEST_CAN_STD_ID_1,
.dlc = 0,
};
int err;

Z_TEST_SKIP_IFNDEF(CONFIG_RUNTIME_ERROR_CHECKS);

err = can_send(can_dev, &frame, TEST_SEND_TIMEOUT, NULL, NULL);
zassert_equal(err, -ENOTSUP, "wrong error on sending invalid frame (err %d)", err);
}
Expand Down
Loading