tests: drivers: can: api: fix misunderstood use of ESI flag #80380
Conversation
Fix the test for sending frames with the CAN_FRAME_ESI flag set. Sending frames with this flag set in software is never allowed. Fixes: 8023a58 Signed-off-by: Henrik Brix Andersen <[email protected]>
henrikbrixandersen
added
the
Hotfix
|
The test introduced in 8023a58 is wrong and holding back both local pre-v4.0.0-rc1 testing and PRs targeting v4.0.0-rc1. |
In my opinion, test introduced in 8023a58 was correct. @henrikbrixandersen : Could You comment on whether there are any errors in my reasoning? [low priority] |
| * @brief Test error when CAN FD Error State Indicator (ESI) is set on transmit frame. | ||
| * | ||
| * CAN FD Error State Indicator (ESI) indicates that the transmitting node is | ||
| * in error-passive state. Only valid in combination with CAN_FRAME_FDF. |
There was a problem hiding this comment.
This was copied from the CAN API documentation at
https://docs.zephyrproject.org/latest/doxygen/html/group__can__interface.html#ga83f8b7af6eb45e43aaac355de3e69e52
Is it worth to make changes there too?
henrikbrixandersen
deleted the
can_tests_api_fix_totally_misunderstood_esi_flag_test
branch
8 participants
Fix the test for sending frames with the CAN_FRAME_ESI flag set. Sending frames with this flag set in software is never allowed.
Fixes: 8023a58