fs: zms: multiple style fixes from previous PR review #80628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: File System
area: Documentation Infrastructure
area: Storage
zephyrbot
requested review from
Laczen,
carlescufi,
de-nordic,
gmarull,
kartben and
nashif
de-nordic
previously approved these changes
Oct 30, 2024
tomi-font
reviewed
Nov 4, 2024
Contributor
tomi-font
left a comment
tomi-font
left a comment
There was a problem hiding this comment.
Not fully done reviewing everything, but dumping what I have already. Starting to look real good!
tomi-font
reviewed
Nov 5, 2024
rghaddab
force-pushed
the
rghaddab/pr-zms-style-fixup-2
branch
from
f8d7586 to
7262258
Compare
Closed
tomi-font
requested changes
Nov 7, 2024
tomi-font
requested changes
Nov 11, 2024
tomi-font
reviewed
Nov 11, 2024
tomi-font
reviewed
Nov 11, 2024
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Contributor
|
@rghaddab Any updates here? |
Contributor
Author
Almost forgot about it. |
This resolves some addressed comments in this PR zephyrproject-rtos#77930 as well as this PR zephyrproject-rtos#80407 Signed-off-by: Riadh Ghaddab <[email protected]>
rghaddab
force-pushed
the
rghaddab/pr-zms-style-fixup-2
branch
from
7262258 to
4eb9876
Compare
de-nordic
approved these changes
Feb 13, 2025
tomi-font
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves some addressed comments in this PR #77930 as well as this PR #80407