tests: Bluetooth: Tester: Format BTP cmd/evt/rsp logs as hex #80740
Conversation
zephyrbot
added
area: Bluetooth
area: Bluetooth Qualification
Thalley
force-pushed
the
btp_logs_update
branch
from
8da0a3a to
309f52a
Compare
tests/bluetooth/tester/src/btp.c
Outdated
There was a problem hiding this comment.
services are defined as decimal
Thalley
force-pushed
the
btp_logs_update
branch
from
309f52a to
c926b0b
Compare
|
@sjanc In the autopts client everything seems to be logged as decimal, e.g. We really should align these so that it's possible to compare not only the definitions, but also the logs. Is there a reason why the services are decimal? |
sjanc
left a comment
sjanc
left a comment
There was a problem hiding this comment.
no reason (other than it is defined like this in autopts docs), we should just switch to hex everywhere
Since the values are defined as hex, e.g. 0x82, it is easier to compare with the log if they also log them as such. Signed-off-by: Emil Gydesen <[email protected]>
Everything else is defined as hex, so it makes sense to be consistent. This will also make it easier to find the service IDs in the logs that primarily already log commands and events as hex. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
btp_logs_update
branch
from
c926b0b to
c62cac5
Compare
|
Since auto-pts/auto-pts#1292 got merged in the auto-pts repo, I pulled in the commit to also change the service to be hexidecimal in this PR. |
6 participants
Since the values are defined as hex, e.g. 0x82, it is easier to compare with the log if they also log them as such.