add checks for optional properties of FPGA iCE40 #80909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add checks in the GPIO bitbang mode to avoid a fault for missing configuration in the devicetree. Fixes zephyrproject-rtos#80850 Signed-off-by: Benedikt Schmidt <[email protected]>
zephyrbot
requested review from
cfriedt,
fkokosinski,
msierszulski and
tgorochowik
josuah
approved these changes
Nov 5, 2024
Comment on lines
+220
to
+229
| if (config->set == NULL) { | ||
| LOG_ERR("%s: set register was not specified", dev->name); | ||
| return -EFAULT; | ||
| } | ||
|
|
||
| if (config->clear == NULL) { | ||
| LOG_ERR("%s: clear register was not specified", dev->name); | ||
| return -EFAULT; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
It might be possible to move this check at build-time by removing the _OR from here:
zephyr/drivers/fpga/fpga_ice40.c
Line 536 in 4bb9453
But it is still allowed to be empty for SPI, so it could be some build assert checking FPGA_ICE40_LOAD_MODE(inst) eventually.
A run-time check is good too!
Member
|
@benediktibk - I would fully support moving these checks to build-time if that works. It's possible that the build_all tests would need to have some arbitrary gpio present. |
cfriedt
approved these changes
Nov 5, 2024
Member
cfriedt
left a comment
cfriedt
left a comment
There was a problem hiding this comment.
Thanks for the fix @benediktibk
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks in the GPIO bitbang mode to avoid a fault for missing configuration in the devicetree.
Fixes #80850