doc: _extensions: scripts: apply ruff lint rules #81092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartben
force-pushed
the
doc_fix_ruff
branch
4 times, most recently
from
c8d3dac to
d29ea82
Compare
Contributor
|
#81070 has been merged 😉 |
Contributor
Author
will come back to this shortly then :) Thank you! |
kartben
force-pushed
the
doc_fix_ruff
branch
from
d29ea82 to
9321e09
Compare
pdgendt
reviewed
Nov 22, 2024
kartben
force-pushed
the
doc_fix_ruff
branch
2 times, most recently
from
50d2398 to
fbc542a
Compare
This makes all Python scripts in doc/_extensions compliant w.r.t current Ruff rules Signed-off-by: Benjamin Cabé <[email protected]>
This makes all remaining Python scripts in doc compliant w.r.t current Ruff rules Signed-off-by: Benjamin Cabé <[email protected]>
kartben
force-pushed
the
doc_fix_ruff
branch
from
fbc542a to
41bb658
Compare
zephyrbot
requested review from
aaronemassey,
asemjonovs,
gmarull,
jeremybettis,
nashif and
yperess
pdgendt
approved these changes
Nov 22, 2024
gmarull
approved these changes
Nov 25, 2024
Contributor
I would add the ignore to the file instead of keeping it in the excludes file. Ideally the excludes file is removed at some point. # Ignore line-too-long to allow for block selection
# ruff: noqa: E501 |
nashif
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all Python scripts in doc/ compliant with current ruff rules.
redirects.pyis kept in the ignore list with regards to line length as keeping the ability to do block selection in this file can be particularly useful.