drivers: i3c: Support I3C driver for STM32. #81190

ExaltZephyr · 2024-11-10T12:54:08Z

This PR introduces support for the I3C driver on STM32, enabling functionality APIs for I3C controllers.

XenuIsWatching

i3c_shell.c also needs updated

zephyr/drivers/i3c/i3c_shell.c

Line 82 in c50777a

DT_FOREACH_STATUS_OKAY(cdns_i3c, I3C_CTRL_FN)

and

zephyr/drivers/i3c/i3c_shell.c

Line 96 in c50777a

DT_FOREACH_STATUS_OKAY(cdns_i3c, I3C_CTRL_LIST_ENTRY)

drivers/i3c/i3c_stm32.c

JarmouniA · 2024-11-10T19:56:47Z

@ExaltZephyr You should put your legal name in Signed-off-by https://docs.zephyrproject.org/latest/contribute/guidelines.html#dco-sign-off

drivers/i3c/i3c_stm32.c

dts/bindings/test/vnd,i3c.yaml

dts/arm/st/h5/stm32h5.dtsi

boards/st/nucleo_h563zi/nucleo_h563zi-common.dtsi

drivers/i3c/i3c_stm32.c

JarmouniA

Merge commit should be dropped.

JarmouniA

The title of each commit should reflect the path of where changes are introduced, see the main branch for examples.

JarmouniA · 2024-11-11T15:25:09Z

@ExaltZephyr You should put your legal name in Signed-off-by https://docs.zephyrproject.org/latest/contribute/guidelines.html#dco-sign-off

Still not fixed. Without this your PR cannot be merged.

erwango · 2024-11-13T09:51:26Z

About Sign-off (Signed-off-by: EXALT Technologies <[email protected]>), the names of groups are not allowed. Please provide one or several developer name. You could use :

Signed-off-by: .....
Co-authored-by: .....

drivers/i3c/i3c_stm32.c

XenuIsWatching

LGTM now... but it looks like there is an unrelated CI failure, you may need to rebase back on top of main

erwango · 2024-12-03T10:31:55Z

Thanks @XenuIsWatching and @ExaltZephyr for the thorough review process!

LGTM now... but it looks like there is an unrelated CI failure, you may need to rebase back on top of main

Need to wait #82363 to be merged.

dts/bindings/test/vnd,i3c.yaml

XenuIsWatching

see comment

erwango · 2024-12-10T08:07:48Z

Please rebase to fix twister CI issues (fixed by #82497)

This commit adds the main DTS configurations required to enable I3C support on STM32. Signed-off-by: Mohammad Badawi <[email protected]> Signed-off-by: Sara Touqan <[email protected]>

This commit introduces support for the I3C driver on STM32, enabling functionality APIs for I3C controllers. Signed-off-by: Mohammad Badawi <[email protected]> Signed-off-by: Sara Touqan <[email protected]>

This commit introduces support for I3C shell on STM32. Signed-off-by: Mohammad Badawi <[email protected]> Signed-off-by: Sara Touqan <[email protected]>

This commit enables I3C support for STM32 nucleo_h563zi boards. Signed-off-by: Mohammad Badawi <[email protected]> Signed-off-by: Sara Touqan <[email protected]>

ExaltZephyr · 2024-12-12T07:41:35Z

The scancode job has been stuck since yesterday.
Do you have any suggestions on how to resolve this issue?
I noticed that I do not have the permissions to retrigger it

kartben · 2024-12-12T09:31:56Z

The scancode job has been stuck since yesterday. Do you have any suggestions on how to resolve this issue? I noticed that I do not have the permissions to retrigger it

Should be back now. GitHub glitch, it would seem.

github-actions · 2024-12-12T10:08:49Z

Hi @ExaltZephyr!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

ExaltZephyr requested a review from dcpleung as a code owner November 10, 2024 12:54

zephyrbot added area: I3C platform: STM32 ST Micro STM32 labels Nov 10, 2024

zephyrbot requested review from FRASTM, GeorgeCGV, XenuIsWatching, erwango, gautierg-st, marwaiehm-st and mathieuchopstm November 10, 2024 12:54

zephyrbot assigned dcpleung Nov 10, 2024

XenuIsWatching requested changes Nov 10, 2024

View reviewed changes

drivers/i3c/i3c_stm32.c Show resolved Hide resolved

drivers/i3c/i3c_stm32.c Outdated Show resolved Hide resolved

drivers/i3c/i3c_stm32.c Show resolved Hide resolved

drivers/i3c/i3c_stm32.c Outdated Show resolved Hide resolved

drivers/i3c/i3c_stm32.c Outdated Show resolved Hide resolved

XenuIsWatching reviewed Nov 10, 2024

View reviewed changes

drivers/i3c/i3c_stm32.c Outdated Show resolved Hide resolved

JarmouniA requested changes Nov 10, 2024

View reviewed changes

drivers/i3c/i3c_stm32.c Outdated Show resolved Hide resolved

dts/bindings/test/vnd,i3c.yaml Show resolved Hide resolved

dts/arm/st/h5/stm32h5.dtsi Show resolved Hide resolved

boards/st/nucleo_h563zi/nucleo_h563zi-common.dtsi Show resolved Hide resolved

XenuIsWatching self-assigned this Nov 10, 2024

XenuIsWatching reviewed Nov 10, 2024

View reviewed changes

drivers/i3c/i3c_stm32.c Outdated Show resolved Hide resolved

ExaltZephyr force-pushed the stm32-i3c-support branch from 5d0e7f0 to 9ddd65f Compare November 11, 2024 10:27

JarmouniA reviewed Nov 11, 2024

View reviewed changes

JarmouniA requested changes Nov 11, 2024

View reviewed changes

ExaltZephyr force-pushed the stm32-i3c-support branch 2 times, most recently from 02f4d4a to 13a048d Compare November 12, 2024 09:06

JarmouniA requested a review from kartben November 12, 2024 10:03

ExaltZephyr force-pushed the stm32-i3c-support branch 2 times, most recently from 0f370bd to e6978f9 Compare November 13, 2024 09:14

ExaltZephyr force-pushed the stm32-i3c-support branch 3 times, most recently from 36c05bf to f43a4b6 Compare November 13, 2024 16:33

ExaltZephyr force-pushed the stm32-i3c-support branch from 97d1fb1 to f32da0b Compare December 1, 2024 09:26

XenuIsWatching reviewed Dec 1, 2024

View reviewed changes

drivers/i3c/i3c_stm32.c Outdated Show resolved Hide resolved

XenuIsWatching reviewed Dec 1, 2024

View reviewed changes

drivers/i3c/i3c_stm32.c Outdated Show resolved Hide resolved

pdgendt reviewed Dec 2, 2024

View reviewed changes

drivers/i3c/i3c_stm32.c Outdated Show resolved Hide resolved

ExaltZephyr force-pushed the stm32-i3c-support branch 2 times, most recently from 365c7f1 to 54e190b Compare December 2, 2024 09:46

XenuIsWatching previously approved these changes Dec 2, 2024

View reviewed changes

erwango mentioned this pull request Dec 3, 2024

mk64f12: test failing with undefined reference to 'z_impl_sys_rand_get' #82344

Closed

ExaltZephyr force-pushed the stm32-i3c-support branch from 54e190b to ca94845 Compare December 3, 2024 09:49

ExaltZephyr dismissed XenuIsWatching’s stale review via 5bba119 December 8, 2024 10:55

ExaltZephyr force-pushed the stm32-i3c-support branch 2 times, most recently from 127a3c7 to 82fc0b6 Compare December 9, 2024 09:10

XenuIsWatching reviewed Dec 9, 2024

View reviewed changes

dts/bindings/test/vnd,i3c.yaml Outdated Show resolved Hide resolved

XenuIsWatching requested changes Dec 9, 2024

View reviewed changes

ExaltZephyr force-pushed the stm32-i3c-support branch 2 times, most recently from 31941ea to d52b5ba Compare December 10, 2024 12:35

ExaltZephyr added 4 commits December 11, 2024 10:40

dts: Add I3C configuration for STM32.

7c00e2c

This commit adds the main DTS configurations required to enable I3C support on STM32. Signed-off-by: Mohammad Badawi <[email protected]> Signed-off-by: Sara Touqan <[email protected]>

drivers: i3c: Support I3C driver for STM32.

e99fe74

This commit introduces support for the I3C driver on STM32, enabling functionality APIs for I3C controllers. Signed-off-by: Mohammad Badawi <[email protected]> Signed-off-by: Sara Touqan <[email protected]>

shell: Enable I3C shell support for STM32.

8e778d5

This commit introduces support for I3C shell on STM32. Signed-off-by: Mohammad Badawi <[email protected]> Signed-off-by: Sara Touqan <[email protected]>

boards: Enable I3C support for STM32 nucleo_h563zi.

9e104d8

This commit enables I3C support for STM32 nucleo_h563zi boards. Signed-off-by: Mohammad Badawi <[email protected]> Signed-off-by: Sara Touqan <[email protected]>

ExaltZephyr force-pushed the stm32-i3c-support branch from d52b5ba to 9e104d8 Compare December 11, 2024 09:19

XenuIsWatching approved these changes Dec 11, 2024

View reviewed changes

erwango removed the block: HW Test Testing on hardware required before merging label Dec 12, 2024

erwango approved these changes Dec 12, 2024

View reviewed changes

kartben merged commit 72acd97 into zephyrproject-rtos:main Dec 12, 2024
26 checks passed

drivers: i3c: Support I3C driver for STM32. #81190

drivers: i3c: Support I3C driver for STM32. #81190

Uh oh!

Conversation

ExaltZephyr commented Nov 10, 2024

Uh oh!

XenuIsWatching left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JarmouniA commented Nov 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JarmouniA left a comment

Choose a reason for hiding this comment

Uh oh!

JarmouniA left a comment

Choose a reason for hiding this comment

Uh oh!

JarmouniA commented Nov 11, 2024

Uh oh!

erwango commented Nov 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

XenuIsWatching left a comment

Choose a reason for hiding this comment

Uh oh!

erwango commented Dec 3, 2024

Uh oh!

Uh oh!

XenuIsWatching left a comment

Choose a reason for hiding this comment

Uh oh!

erwango commented Dec 10, 2024

Uh oh!

ExaltZephyr commented Dec 12, 2024

Uh oh!

kartben commented Dec 12, 2024

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants