net: icmp: fix warn on allocating net_buf #81208
Conversation
net_buf_alloc_len will hard set timeout to 0 when it is in sys workq thread and print warning log. send_icmpv4_echo_request and send_icmpv6_echo_request are both allocating net_buf with timeout PKT_WAIT_TIME 1s. This will cause warning log in every icmp send and actual timeout is 0. So fix it by always setting it to 0. Signed-off-by: Fengming Ye <[email protected]>
zephyrbot
requested review from
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
jukkar
left a comment
jukkar
left a comment
There was a problem hiding this comment.
I don't think this is a good idea, you are now disabling the timeout for all use cases. The net_buf_ alloc_len will set the timeout to K_NO_WAIT anyway so doing it here is not really needed. If you are worried about the warning message, then I suggest the message is changed to LOG_DBG() in net_buf_alloc_len() instead.
send_icmpv4_echo_request and send_icmpv6_echo_request are both static used in ping_work. They will not be used by other use cases and timeout is always 0 for a long time. This log level is recently increased from debug to warn by 88ee2be. |
|
There is an alternate implementation that will avoid the warning print but still allows timeout to be set at #83116 |
|
Closing this as the issue is implemented differently in main. |
4 participants
net_buf_alloc_len will hard set timeout to 0 when
it is in sys workq thread and print warning log.
send_icmpv4_echo_request and send_icmpv6_echo_request are both allocating net_buf with timeout PKT_WAIT_TIME 1s. This will cause warning log in every icmp send and actual timeout is 0.
So fix it by always setting it to 0.