Skip to content

net: icmp: fix warn on allocating net_buf #81208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fengming-ye wants to merge 1 commit into from
Closed

net: icmp: fix warn on allocating net_buf #81208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions subsys/net/ip/icmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@
static sys_slist_t offload_handlers = SYS_SLIST_STATIC_INIT(&offload_handlers);
#endif

#define PKT_WAIT_TIME K_SECONDS(1)

int net_icmp_init_ctx(struct net_icmp_ctx *ctx, uint8_t type, uint8_t code,
net_icmp_handler_t handler)
{
Expand Down Expand Up @@ -140,8 +138,8 @@
sizeof(struct net_icmpv4_echo_req)
+ params->data_size,
AF_INET, IPPROTO_ICMP,
PKT_WAIT_TIME);
K_NO_WAIT);
if (!pkt) {

Check notice on line 142 in subsys/net/ip/icmp.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

subsys/net/ip/icmp.c:142 
-					sizeof(struct net_icmpv4_echo_req)
-					+ params->data_size,
-					AF_INET, IPPROTO_ICMP,
-					K_NO_WAIT);
+					sizeof(struct net_icmpv4_echo_req) + params->data_size,
+					AF_INET, IPPROTO_ICMP, K_NO_WAIT);
return -ENOMEM;
}

Expand Down Expand Up @@ -261,8 +259,8 @@
sizeof(struct net_icmpv6_echo_req)
+ params->data_size,
AF_INET6, IPPROTO_ICMPV6,
PKT_WAIT_TIME);
K_NO_WAIT);
if (!pkt) {

Check notice on line 263 in subsys/net/ip/icmp.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

subsys/net/ip/icmp.c:263 
-					sizeof(struct net_icmpv6_echo_req)
-					+ params->data_size,
-					AF_INET6, IPPROTO_ICMPV6,
-					K_NO_WAIT);
+					sizeof(struct net_icmpv6_echo_req) + params->data_size,
+					AF_INET6, IPPROTO_ICMPV6, K_NO_WAIT);
return -ENOMEM;
}

Expand Down
Loading