Skip to content

Conversation

@kaessert
Copy link
Contributor

@kaessert kaessert commented Nov 17, 2024

This PR adds support for the Lilygo TTGO T7 V1.5 baord. It's my first pr of that kind so please be gentle with me :)

@github-actions
Copy link

Hello @kaessert, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@kaessert
Copy link
Contributor Author

Thank you so much for your review @nordicjm ! I addressed the comments.

@kaessert kaessert requested a review from nordicjm November 19, 2024 08:44
@kaessert
Copy link
Contributor Author

Thank you so much for your patience 🙏

@nordicjm
Copy link
Contributor

Can you squash the commits down to one commit?

@kaessert
Copy link
Contributor Author

@nordicjm Sure, squashed

@kaessert kaessert force-pushed the lilygo_ttgo_t7v1_5 branch 4 times, most recently from 4e116ae to de37bec Compare November 27, 2024 13:52
@kaessert kaessert force-pushed the lilygo_ttgo_t7v1_5 branch 2 times, most recently from 83e2b08 to db5404e Compare November 27, 2024 19:57
Add support for board "Lilygo TTGO T7 V1.5"

Signed-off-by: Tobias Kässer <[email protected]>
@kaessert
Copy link
Contributor Author

Found and fixed an error in my appcpu-defconfig. Tests should pass now.

@kartben kartben merged commit 887f210 into zephyrproject-rtos:main Dec 2, 2024
18 checks passed
@github-actions
Copy link

github-actions bot commented Dec 2, 2024

Hi @kaessert!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@kaessert
Copy link
Contributor Author

kaessert commented Dec 2, 2024

Thanks for your support everybody!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants