Skip to content

Conversation

@jilaypandya
Copy link
Member

@jilaypandya jilaypandya commented Dec 16, 2024

create rampstat Kconfig template to enable respective tmc drivers to reuse the common configurations

PR to facilitate #80784

create rampstat Kconfig template to enable respective tmc drivers to
reuse the common configurations

Signed-off-by: Jilay Pandya <[email protected]>
rename CONFIG_STEPPER_ADI_RAMP_GEN to CONFIG_STEPPER_ADI_TMC5041_RAMP_GEN

Signed-off-by: Jilay Pandya <[email protected]>
@jilaypandya jilaypandya force-pushed the feature/rectify-tmc5041-kconfig branch from 152ae03 to 37e28b6 Compare December 16, 2024 19:08
@jilaypandya jilaypandya changed the title drivers: stepper: tmc: create rampstat Kconfig template drivers: stepper: tmc: create rampgen Kconfig template Dec 16, 2024
@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Dec 16, 2024
@zephyrbot zephyrbot requested a review from kartben December 16, 2024 19:21
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc: migration guide: 4.1:add deprecation info of STEPPER_ADI_TMC_RAMP_GEN
                         ^
                         '--- missing space

@jilaypandya
Copy link
Member Author

doc: migration guide: 4.1:add deprecation info of STEPPER_ADI_TMC_RAMP_GEN
                         ^
                         '--- missing space

Already reached 75 characters :)

@fabiobaltieri
Copy link
Member

Already reached 75 characters :)

Is that enforced? I think that's more of a suggestion

@jilaypandya jilaypandya force-pushed the feature/rectify-tmc5041-kconfig branch 2 times, most recently from b03430a to 68f470e Compare December 17, 2024 12:53
…MP_GEN

STEPPER_ADI_TMC_RAMP_GEN renamed to template STEPPER_ADI_TMC5041_RAMP_GEN

Signed-off-by: Jilay Pandya <[email protected]>
@jilaypandya jilaypandya force-pushed the feature/rectify-tmc5041-kconfig branch from 68f470e to 7c5f0df Compare December 17, 2024 14:19
Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool :)

@kartben kartben merged commit 157a366 into zephyrproject-rtos:main Dec 18, 2024
24 checks passed
@jilaypandya jilaypandya deleted the feature/rectify-tmc5041-kconfig branch December 19, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Stepper Release Notes To be mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants