Bluetooth: ATT: Disconnect ATT and ACL when receiving inval rsp #83222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
att_disconnect
branch
from
7f524c5 to
a537a03
Compare
Contributor
Author
|
https://bluetooth.atlassian.net/browse/ES-26081 also briefly touches on this subject. It's is generally undefined how a GATT client should handle unsolicited responses. |
When we receive a response from a server we do not have an outstanding request with, we disconnect the connection rather than just ignoring it. The reason for this is that the remote server is not ensuring correct ATT flow control, which means that we cannot trust future responses from the server. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
commented
Feb 6, 2025
Thalley
force-pushed
the
att_disconnect
branch
from
a537a03 to
099a418
Compare
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
zephyrbot
requested review from
alwa-nordic,
cvinayak,
hermabe,
rugeGerritsen,
sjanc and
theob-pro
alwa-nordic
approved these changes
Feb 6, 2025
jhedberg
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we receive a response from a server we do not have an outstanding request with, we disconnect the connection rather than just ignoring it.
The reason for this is that the remote server is
not ensuring correct ATT flow control, which means that we cannot trust future responses from the
server.
Relates to #81432
Once this has gone through, similar changes to GATT will be implemented where invalid responses will be considered a disconnectable reason