soc: nordic: nrf54h: Add option to use NFCT pins as GPIOs #86280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protection circuit must be disabled to use NFCT antenna pins as GPIOs. It can be done by adding nfct-pins-as-gpios to nfct node in the devicetree in cpuapp. Node must be disabled as NFCT is not used. In legacy platforms same property was added to uicr node because that information was stored in UICR. In nrf54h20 it is not part of UICR so property is part of nfct node. Signed-off-by: Krzysztof Chruściński <[email protected]>
zephyrbot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
nika-nordic
reviewed
Feb 25, 2025
| nrf_spu_periph_perm_dmasec_set(spu, nrf_address_slave_get(ccm030_addr), true); | ||
| #endif | ||
|
|
||
| if (DT_NODE_HAS_STATUS(DT_NODELABEL(nfct), disabled) && |
There was a problem hiding this comment.
shouldn't the NFCT node be reserved rather than disabled ?
status == reserved ensures that ownership of NFCT peripheral is assigned to given local domain.
On the other hand, status == okay should not be used because it might implicitly activate NFCT driver (not an issue now, but to be future-proof)
There was a problem hiding this comment.
NFCT is by default assigned to cpuapp so it can access NFCT registers by default no need to reserving.
There was a problem hiding this comment.
This limits use of NFCT pins to cpuapp.
When I try to use that GPIOs by cpurad I see:
- cpurad not booting because it tries to access registers of NFCT that it doesn't own
&nfct {
compatible = "nordic,nrf-nfct-v2";
status = "disabled";
nfct-pins-as-gpios;
};
- NFC not disabled because condition from line 155 is not meet
&nfct {
compatible = "nordic,nrf-nfct-v2";
status = "okay";
nfct-pins-as-gpios;
};
kl-cruz
approved these changes
Mar 11, 2025
|
@masz-nordic @anangl can you take a look? |
masz-nordic
approved these changes
Mar 12, 2025
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
May 20, 2025
Align to changes made in zephyrproject-rtos/zephyr#86280 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-piks
pushed a commit
to nrfconnect/sdk-nrf
that referenced
this pull request
May 21, 2025
Align to changes made in zephyrproject-rtos/zephyr#86280 Signed-off-by: Sebastian Głąb <[email protected]>
|
Requires the following change in the Kconfig option that represents the DTS configuration for NFCT: -> |
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protection circuit must be disabled to use NFCT antenna pins as GPIOs. It can be done by adding nfct-pins-as-gpios to nfct node in the devicetree in cpuapp. Node must be disabled as NFCT is not used. In legacy platforms same property was added to uicr node because that information was stored in UICR. In nrf54h20 it is not part of UICR so property is part of nfct node.