Skip to content

[Backport v4.0-branch] drivers: gpio: adp5585: fix wrong output register during pin configure #86842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

[Backport v4.0-branch] drivers: gpio: adp5585: fix wrong output register during pin configure #86842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions drivers/gpio/gpio_adp5585.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,16 +143,16 @@
data->output |= BIT(pin);
}
if (bank == 0) {
/* reg_value for ADP5585_GPO_OUT_MODE */
/* reg_value for ADP5585_GPO_DATA_OUT */
reg_value = (uint8_t)data->output;
} else {
/* reg_value for ADP5585_GPO_OUT_MODE */
/* reg_value for ADP5585_GPO_DATA_OUT */
reg_value = (uint8_t)(data->output >> 8);
}
ret = i2c_reg_write_byte_dt(&parent_cfg->i2c_bus,
ADP5585_GPO_OUT_MODE_A + bank,
ADP5585_GPO_DATA_OUT_A + bank,
reg_value);
if (ret != 0) {

Check notice on line 155 in drivers/gpio/gpio_adp5585.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

drivers/gpio/gpio_adp5585.c:155 
-		ret = i2c_reg_write_byte_dt(&parent_cfg->i2c_bus,
-					ADP5585_GPO_DATA_OUT_A + bank,
-					reg_value);
+		ret = i2c_reg_write_byte_dt(&parent_cfg->i2c_bus, ADP5585_GPO_DATA_OUT_A + bank,
+					    reg_value);

Check notice on line 155 in drivers/gpio/gpio_adp5585.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

drivers/gpio/gpio_adp5585.c:155 
-		ret = i2c_reg_write_byte_dt(&parent_cfg->i2c_bus,
-					ADP5585_GPO_DATA_OUT_A + bank,
-					reg_value);
+		ret = i2c_reg_write_byte_dt(&parent_cfg->i2c_bus, ADP5585_GPO_DATA_OUT_A + bank,
+					    reg_value);

Check notice on line 155 in drivers/gpio/gpio_adp5585.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

drivers/gpio/gpio_adp5585.c:155 
-		ret = i2c_reg_write_byte_dt(&parent_cfg->i2c_bus,
-					ADP5585_GPO_DATA_OUT_A + bank,
-					reg_value);
+		ret = i2c_reg_write_byte_dt(&parent_cfg->i2c_bus, ADP5585_GPO_DATA_OUT_A + bank,
+					    reg_value);

Check notice on line 155 in drivers/gpio/gpio_adp5585.c

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

drivers/gpio/gpio_adp5585.c:155 
-		ret = i2c_reg_write_byte_dt(&parent_cfg->i2c_bus,
-					ADP5585_GPO_DATA_OUT_A + bank,
-					reg_value);
+		ret = i2c_reg_write_byte_dt(&parent_cfg->i2c_bus, ADP5585_GPO_DATA_OUT_A + bank,
+					    reg_value);
goto out;
}
/* reg_value for ADP5585_GPIO_DIRECTION */
Expand Down
Loading