[Backport v3.7-branch] Fix DNS response parsing #87949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdgendt
previously approved these changes
Apr 1, 2025
rlubos
previously approved these changes
Apr 1, 2025
The DNS_EAI_SYSTEM error value tells that the errno value contains the actual system error value. So set the errno properly when there is a system error. Signed-off-by: Jukka Rissanen <[email protected]>
Make sure that the CNAME handling checks recursive name pointers and fails the response if recursion is detected. See RFC 9267 ch. 2 for details. Signed-off-by: Jukka Rissanen <[email protected]>
Add checks that we will be able to catch recursive name pointers and abandon the response for CNAME handling. Signed-off-by: Jukka Rissanen <[email protected]>
Allow only 0xc (0b11) as two highest bit to mark the compression when parsing the CNAME response. See RFC 9267 ch. 2 for details. Signed-off-by: Jukka Rissanen <[email protected]>
Add checks that we will be able to catch invalid compression bit in response CNAME handling. Signed-off-by: Jukka Rissanen <[email protected]>
jukkar
force-pushed
the
backport-87753-to-v3.7-branch
branch
from
4eb6c87 to
05469bc
Compare
|
Needed to backport this commit 0e88a8b from main to fix the error code handling and allow the tests to pass. |
rlubos
approved these changes
Apr 1, 2025
pdgendt
approved these changes
Apr 1, 2025
nashif
merged commit f23e4e1
into
zephyrproject-rtos:v3.7-branch
24 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e58407c~4..e58407c from #87753.
Fixes #87947