posix: timers: correct pointer passed to k_mem_slab_free() #88193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it is not possible to create a timer in timer_create(), then the timer_obj associated with the timer must be freed. However, the address of the pointer was mistakenly being passed to k_mem_slab_free() rather than simply the the pointer. This caused a crash in tests which can easily be avoided by passing the pointer rather than the address of the pointer. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
time-tests-not-run-for-qemu-riscv64
branch
2 times, most recently
from
6a42b8d to
60c9a25
Compare
timer_create() will error if there are no dynamic threads to run the SIGEV_THREAD handler, causing the test to fail (where it was previously expected to pass). Ensure that there is at least 1 dynamic thread available to the POSIX API. Signed-off-by: Chris Friedt <[email protected]>
I just happened to try to run this testsuite manually today and noticed that it was being skipped due to a copy-paste error. This test was migrated from tests/posix/common, where tests were skipped for non-dynamic threads, since it would mostly duplicate tests that had already been run. However, while migrating, the condition to skip tests was mistakenly left in when it should not have been. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
time-tests-not-run-for-qemu-riscv64
branch
from
60c9a25 to
059087c
Compare
cfriedt
added
the
area: Tests
ycsin
approved these changes
Apr 12, 2025
Member
Author
|
Just adding other reviewers to get a second approval. |
JordanYates
approved these changes
Apr 14, 2025
jukkar
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k_mem_slab_free()Fixes #88192
Fixes #88194