Skip to content

posix: timers: correct pointer passed to k_mem_slab_free() #88193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kartben merged 3 commits into from
Apr 16, 2025
Merged

posix: timers: correct pointer passed to k_mem_slab_free() #88193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38293af
posix: timers: correct pointer passed to k_mem_slab_free()
cfriedt Apr 5, 2025
f4c7948
tests: posix: timers: provide at least 1 dynamic thread
cfriedt Apr 5, 2025
059087c
tests: posix: timer: do not skip tests
cfriedt Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/posix/options/timer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ int timer_create(clockid_t clockid, struct sigevent *evp, timer_t *timerid)
goto out;

free_timer:
k_mem_slab_free(&posix_timer_slab, (void *)&timer);
k_mem_slab_free(&posix_timer_slab, (void *)timer);

out:
return ret;
Expand Down
5 changes: 5 additions & 0 deletions tests/posix/timers/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,8 @@ CONFIG_ZTEST=y

CONFIG_POSIX_AEP_CHOICE_BASE=y
CONFIG_POSIX_TIMERS=y

# Needed for timer_create() when using SIGEV_THREAD
CONFIG_DYNAMIC_THREAD=y
CONFIG_DYNAMIC_THREAD_POOL_SIZE=1
CONFIG_THREAD_STACK_INFO=y
12 changes: 1 addition & 11 deletions tests/posix/timers/src/timer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,4 @@ static void after(void *arg)
}
}

static void before(void *arg)
{
ARG_UNUSED(arg);

if (!IS_ENABLED(CONFIG_DYNAMIC_THREAD)) {
/* skip redundant testing if there is no thread pool / heap allocation */
ztest_test_skip();
}
}

ZTEST_SUITE(posix_timers, NULL, NULL, before, after, NULL);
ZTEST_SUITE(posix_timers, NULL, NULL, NULL, after, NULL);