drivers: fuelgauge: Add Onsemi LC709203F driver #89000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aaronemassey,
kartben,
nashif and
teburd
There was a problem hiding this comment.
Pull Request Overview
This PR adds an Onsemi LC709203F fuel gauge driver along with samples, DTS binding, header updates, and an emulator implementation.
- Introduces main sample application to demonstrate fuel gauge usage.
- Updates fuel gauge header definitions and DTS binding to support new properties.
- Provides an emulator implementation for testing.
Reviewed Changes
Copilot reviewed 13 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| samples/fuel_gauge/lc709203f/src/main.c | Implements sample app; contains a redundant dev check. |
| samples/fuel_gauge/lc709203f/sample.yaml | Provides sample configuration for the fuel gauge. |
| include/zephyr/drivers/fuel_gauge.h | Adds new fuel gauge properties. |
| dts/bindings/fuel-gauge/onnn,lc709203f.yaml | Adds DTS binding for the LC709203F fuel gauge. |
| drivers/fuel_gauge/lc709203f/lc709203f.h | Declares registers and APIs for the new driver. |
| drivers/fuel_gauge/lc709203f/emul_lc709203f.c | Implements an emulator for the LC709203F fuel gauge. |
Files not reviewed (14)
- boards/adafruit/feather_esp32s2/doc/adafruit_feather_esp32s2.rst: Language not supported
- boards/adafruit/feather_esp32s2/doc/adafruit_feather_esp32s2_tft.rst: Language not supported
- boards/adafruit/feather_esp32s2/doc/adafruit_feather_esp32s2_tft_reverse.rst: Language not supported
- drivers/fuel_gauge/CMakeLists.txt: Language not supported
- drivers/fuel_gauge/Kconfig: Language not supported
- drivers/fuel_gauge/lc709203f/CMakeLists.txt: Language not supported
- drivers/fuel_gauge/lc709203f/Kconfig: Language not supported
- samples/fuel_gauge/lc709203f/CMakeLists.txt: Language not supported
- samples/fuel_gauge/lc709203f/README.rst: Language not supported
- samples/fuel_gauge/lc709203f/boards/adafruit_feather_esp32s2.conf: Language not supported
- samples/fuel_gauge/lc709203f/boards/adafruit_feather_esp32s2.overlay: Language not supported
- samples/fuel_gauge/lc709203f/boards/adafruit_feather_esp32s2_tft.conf: Language not supported
- samples/fuel_gauge/lc709203f/boards/adafruit_feather_esp32s2_tft.overlay: Language not supported
- samples/fuel_gauge/lc709203f/prj.conf: Language not supported
DBS06
force-pushed
the
add_LC709203F_fuel_gauge_driver
branch
from
b168287 to
aedd521
Compare
kartben
requested changes
Apr 24, 2025
boards/adafruit/feather_esp32s2/doc/adafruit_feather_esp32s2.rst
Outdated
Show resolved
Hide resolved
kartben
reviewed
Apr 24, 2025
Contributor
kartben
left a comment
kartben
left a comment
There was a problem hiding this comment.
Also please separate in multiple commits as it is doing more than just adding a new driver (i.e. adding new fuel gauge property typed)
Contributor
Author
I will split the commits asap |
Contributor
Author
Thanks a lot for this fast reply! |
DBS06
force-pushed
the
add_LC709203F_fuel_gauge_driver
branch
3 times, most recently
from
b1096dd to
7569d0a
Compare
Contributor
Author
I split up the commit into multiple commits in a way which I think makes sense |
Contributor
Author
|
overview which is still missing or needs/should/wished to be changed
|
DBS06
force-pushed
the
add_LC709203F_fuel_gauge_driver
branch
10 times, most recently
from
ddebd24 to
d9af45c
Compare
github-actions
bot
added
manifest-picolibc
manifest-babblesim_ext_2G4_phy_v1
manifest-hal_nxp
manifest-cmsis_6
manifest-hal_stm32
manifest-babblesim_base
manifest-zephyr-lang-rust
manifest-nrf_hw_models
manifest-hal_bouffalolab
manifest-hal_st
manifest-bsim
manifest-nrf_wifi
manifest-hal_ambiq
manifest-hal_espressif
manifest-hal_nordic
manifest-hal_altera
manifest-hal_ti
manifest-hal_infineon
manifest-mcuboot
manifest-littlefs
manifest-hal_renesas
manifest-trusted-firmware-m
manifest-hal_adi
manifest-hal_silabs
DNM (manifest)
|
Contributor
Author
|
I messed up the commits due to GitHub's merge conflict solver, therefore I will close this PR and recreate the PR see #90310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add driver for the Onsemi LC709203F fuel gauge