drivers: fuelgauge: Add Onsemi LC709203F driver and refactor fuelgauge sample #90310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aaronemassey,
kartben,
nashif and
teburd
Contributor
Author
teburd
previously approved these changes
Jun 2, 2025
kartben
requested changes
Jun 3, 2025
kartben
reviewed
Jun 3, 2025
kartben
reviewed
Jun 3, 2025
kartben
reviewed
Jun 3, 2025
kartben
reviewed
Jun 3, 2025
Contributor
Author
|
@kartben First, thanks a lot for your profound review! Edit: @kartben I pushed right now your requested changes |
DBS06
force-pushed
the
add_LC709203F_fuel_gauge
branch
from
12a8422 to
34d9283
Compare
Adds properties for current direction, charge and voltage alarms Signed-off-by: Philipp Steiner <[email protected]>
format fuel_gauge.h according to the clang-format settings Signed-off-by: Philipp Steiner <[email protected]>
Add driver for the Onsemi LC709203F fuel gauge Signed-off-by: Philipp Steiner <[email protected]>
Add test for the Onsemi LC709203F fuel gauge Signed-off-by: Philipp Steiner <[email protected]>
update because of LC709203F driver was added Signed-off-by: Philipp Steiner <[email protected]>
DBS06
force-pushed
the
add_LC709203F_fuel_gauge
branch
from
34d9283 to
7fe13ee
Compare
Replace IC specific fuel gauge example with a generic fuel gauge example and move the fuel gauge sample to sample/drivers folder Signed-off-by: Philipp Steiner <[email protected]>
DBS06
force-pushed
the
add_LC709203F_fuel_gauge
branch
from
7fe13ee to
e2f2920
Compare
|
kartben
approved these changes
Jun 26, 2025
Contributor
|
@teburd can you please take another look / refresh your +1? Thanks! |
teburd
approved these changes
Jun 26, 2025
This was referenced Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
I had to redo the PR #89000, because in my original PR I messed up the commits due to GitHub's merge conflict solver.