[Backport v3.7-branch] logging: fixes and enhancements to initialization and shell cmds #89318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-krch
approved these changes
May 5, 2025
kwd-doodling
approved these changes
May 6, 2025
The `id` is basically a compile-time constant. Setting it every time the backend is enabled is unnecessary. Instead, set it on `log_core_init()` regardless of whether or not it requires to be `autostart`ed. Fixes an issue where the `filter_get`/`filter_set` accessed the wrong index and displayed the wrong log level when user accesses the status of an uninitialized backend via: `log backend <uninitialized_backend> status`. Also fixes an issue when user tries to list the backends via: `log list_backends`, where all uninitialized backends will have ID = 0. This commit is a combination of 8dd9d92 & dd9fd7d. Signed-off-by: Yong Cong Sin <[email protected]> Signed-off-by: Yong Cong Sin <[email protected]>
For backends that do not autostart themselves, initialize & enable them on `log backend <log_backend_*> go`, so that they function properly. Signed-off-by: Yong Cong Sin <[email protected]> Signed-off-by: Yong Cong Sin <[email protected]>
nashif
force-pushed
the
pr/v3.7-branch-backport-85159
branch
from
d9d6b62 to
9e927fb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from #84955 + #87097
The fix in #84955 introduce a bug which is fixed later by #87097, this PR is a combination of both, so that it fixes things without introducing bugs
Fixes #84952
Test
Before the patch
Full console log
After the patch: