Skip to content

Add Support Artery Technology AT32F405(ARM Cortex M4F) SoC. #91273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add Support Artery Technology AT32F405(ARM Cortex M4F) SoC. #91273

wants to merge 12 commits into from

Conversation

Maxjta
Copy link

@Maxjta Maxjta commented Jun 9, 2025

This PR adds support for Artery Technology [AT32F405RCT7) SoC.
This is a new microcontroller manufacturer, website link：https://www.arterychip.com/

Currently, the west module dependency points to https://github.com/Maxjta/hal_at32
At this time, Only samples/basic/blinky is work. Other drivers will be added later.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_at32 🆕 N/A (Added) Maxjta/hal_at32@2c8de65 (main) N/A

⛔ DNM label due to: 1 added project

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_at32 DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jun 9, 2025
ycsin
ycsin reviewed Jun 9, 2025
View reviewed changes
Copy link
Member

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • there should be an empty line at the end of each file
  • please format the *.[c|h] files with clang-format

@Maxjta
Copy link
Author

Maxjta commented Jun 10, 2025

@ycsin Thanks.
The following issue has been fixed.

  • there should be an empty line at the end of each file
  • please format the *.[c|h] files with clang-format

nordicjm
nordicjm requested changes Jun 10, 2025
View reviewed changes
@nordicjm nordicjm requested a review from kartben June 10, 2025 07:24
kartben
kartben reviewed Jun 10, 2025
View reviewed changes
@decsny decsny removed their request for review June 16, 2025 19:21
@Maxjta Maxjta requested a review from nordicjm June 24, 2025 07:12
@zephyrbot zephyrbot requested a review from mbolivar July 22, 2025 07:04
nordicjm
nordicjm requested changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No fixup commits

@Maxjta
Copy link
Author

Maxjta commented Aug 5, 2025

@nordicjm Could you tell me where I need to modify it? Do I need to add other peripheral drivers? Thank you.

@nordicjm
Copy link
Contributor

nordicjm commented Aug 5, 2025

@nordicjm Could you tell me where I need to modify it? Do I need to add other peripheral drivers? Thank you.

You add stuff, revert stuff, then edit stuff, there should be one commit for adding the board, there should be no reverts, etc.

@Maxjta
Copy link
Author

Maxjta commented Aug 5, 2025

@nordicjm Could you tell me where I need to modify it? Do I need to add other peripheral drivers? Thank you.

You add stuff, revert stuff, then edit stuff, there should be one commit for adding the board, there should be no reverts, etc.

OK, I will close this PR, and request a new PR.

@zephyrbot zephyrbot added the area: UART Universal Asynchronous Receiver-Transmitter label Sep 2, 2025
@zephyrbot zephyrbot requested a review from gmarull September 2, 2025 05:30
@Maxjta Maxjta force-pushed the zephyr-rtos branch 4 times, most recently from 2781c70 to fb9d329 Compare September 3, 2025 10:08
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 3, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ubieda ubieda mentioned this pull request Sep 23, 2025
Open
mbolivar
mbolivar requested changes Oct 8, 2025
View reviewed changes
dts/bindings/vendor-prefixes.txt Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a quite short symbol which feels like it might conflict with a stock ticker symbol. Please use something longer unless this is actually the ticker symbol for this corporation on a major exchange.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbolivar Thanks for your suggestion， I will modify “at” to “artery”.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maxjta please fix the file names to match the change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maxjta please fix the file names to match the change.

@mbolivar Could you please tell me which file names need to be modified? If it is “at32”, “at32” is the abbreviation of Artery MCU.

Maxjta added 7 commits October 10, 2025 14:11
@Maxjta
soc: artery: Add AT32F405 soc related code and configuration files.
48dd819 
Add AT32F405 soc related code and configuration files.

Signed-off-by: jun tan <[email protected]>
@Maxjta
driver: clock_control: add clock control driver
c7d0bf3 
Add clock control driver to support AT32F405

Signed-off-by: jun tan <[email protected]>
@Maxjta
driver: gpio: add gpio driver to support AT32F405
c56465a 
Add gpio driver to support AT32F405

Signed-off-by: jun tan <[email protected]>
@Maxjta
driver: interrupt_controller: add interrupt controller driver.
866c8dc 
Add interrupt controller driver to support AT32F405.

Signed-off-by: jun tan <[email protected]>
@Maxjta
driver: usart: add usart driver to support AT32F405
7158916 
Add usart driver to support AT32F405

Signed-off-by: jun tan <[email protected]>
@Maxjta
driver: pinctrl: add pinctrl driver.
696dfe7 
Add pinctrl driver to support AT32F405.

Signed-off-by: jun tan <[email protected]>
@Maxjta
driver: reset: add reset driver.
f831b57 
Add reset driver to support AT32F405.

Signed-off-by: jun tan <[email protected]>
@zephyrbot zephyrbot requested a review from mbolivar October 10, 2025 06:34
@Maxjta Maxjta force-pushed the zephyr-rtos branch 2 times, most recently from 8fbd143 to 4f02706 Compare October 14, 2025 01:35
Maxjta added 5 commits October 14, 2025 09:39
@Maxjta
dts: bingdings/arm: Add devicetree and dirver tree
333a2e3 
Add AT32F405 devicetree and clock, gpio, misc,
usart, pinctrl drivertree.

Signed-off-by: jun tan <[email protected]>
@Maxjta
include: add clock control/interrupt controller api.
314b1ed 
Add clock and interrupt public api and define.

Signed-off-by: jun tan <[email protected]>
@Maxjta
board: artery: add AT32F405 AT-START board support.
360bd98 
Add support AT-START-F405 board.

Signed-off-by: jun tan <[email protected]>
@Maxjta
modules: artery: add new modules hal_at32 to support AT32F405.
4d73a06 
-the hal driver name: hal_at32
link: https://github.com/Maxjta/hal_at32

Signed-off-by: jun tan <[email protected]>
@Maxjta
MAINTAINERS: Add West project hal_at32.
ac80b36 
MAINTAINERS add west project hal_at32 and maintainers

Signed-off-by: jun tan <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartben kartben kartben left review comments

@ycsin ycsin ycsin left review comments

@nordicjm nordicjm nordicjm requested changes

@dcpleung dcpleung Awaiting requested review from dcpleung

@galak galak Awaiting requested review from galak

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@mnkp mnkp Awaiting requested review from mnkp

@nashif nashif Awaiting requested review from nashif

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@rruuaanng rruuaanng Awaiting requested review from rruuaanng

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@stephanosio stephanosio Awaiting requested review from stephanosio

@gmarull gmarull Awaiting requested review from gmarull

@mbolivar mbolivar Awaiting requested review from mbolivar

Requested changes must be addressed to merge this pull request.

Assignees

@nordic-krch nordic-krch

Labels

area: Boards/SoCs area: Clock Control area: Devicetree Bindings area: Devicetree area: GPIO area: Interrupt Controller area: MAINTAINER File area: Pinctrl area: Process area: UART Universal Asynchronous Receiver-Transmitter DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_at32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Maxjta @nordicjm @kartben @mbolivar @ycsin @nordic-krch @zephyrbot