Revert #90014 due to multiple issues with older compilers #93158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 49a96f6. Signed-off-by: Anas Nashif <[email protected]>
…test" This reverts commit c341f53. Signed-off-by: Anas Nashif <[email protected]>
…ities.py" This reverts commit 653f1bf. Signed-off-by: Anas Nashif <[email protected]>
…ects" This reverts commit 175da6b. Signed-off-by: Anas Nashif <[email protected]>
github-actions
bot
added
area: Build System
area: Networking
area: Sockets
github-actions
bot
requested review from
57300,
TaiJuWu,
andyross,
ceolin,
cfriedt,
dcpleung,
jeremybettis,
jukkar,
nordicjm,
npitre,
pdgendt,
peter-mitsis,
rlubos and
tejlmand
|
Member
Author
|
this #92510 also references those commits |
cfriedt
approved these changes
Jul 15, 2025
nordicjm
approved these changes
Jul 16, 2025
1 task
Member
Author
|
@tejlmand is out and he is not the right assignee anyways |
Contributor
I agree (back from vacation), as we are already in RC phase. @nashif besides #93017, was there any other issues since you stated "multiple issues with older compilers" so I guess it is not the only one then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#90014
Fixes #93020
Need to revisit that after the release and make sure it is compatible with supported compilers used in Zephyr.