ipm: clarify wait parameter interpretation
#94020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcpleung
reviewed
Aug 4, 2025
dsseng
force-pushed
the
ipm-clarify-wait
branch
from
2cf366b to
47e195d
Compare
Wait acts as a boolean, make this clear to avoid implementations interpreting this as a duration to wait for. Signed-off-by: Dmitrii Sharshakov <[email protected]>
dsseng
force-pushed
the
ipm-clarify-wait
branch
from
47e195d to
c59d535
Compare
|
dcpleung
approved these changes
Aug 11, 2025
kartben
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait acts as a boolean, make this clear to avoid implementations
interpreting this as a duration to wait for.
See #92923 (comment) for the reference
Signed-off-by: Dmitrii Sharshakov [email protected]