-
Notifications
You must be signed in to change notification settings - Fork 8.1k
manifest: hal_rpi_pico: Update to SDK 2.2.0 #94247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
298fffd
to
7a55cc6
Compare
|
Could you take a look, please? |
@ajf58 Please rebase. |
Sort some entries alphabetically to improve readability and maintainability. This commit just reorders existing entries and does not change any include paths. Signed-off-by: Andrew Featherstone <[email protected]>
Update the Raspberry Pi Pico HAL to be based on the latest release of the upstream SDK (v2.2.0). SDK v2.2.0 has new include directory structure, so update the relevant CMakeLists.txt files accordingly. Signed-off-by: Andrew Featherstone <[email protected]>
v2.1.1 onwards of the SDK increases the default. Update the binding to match. See raspberrypi/pico-sdk#2245 Signed-off-by: Andrew Featherstone <[email protected]>
7a55cc6
to
9e1a72c
Compare
|
@ThreeEights |
Could you take a look, please? |
${rp2_common_dir}/hardware_sync/include | ||
${rp2_common_dir}/hardware_timer/include | ||
${rp2_common_dir}/hardware_pll/include | ||
${rp2_common_dir}/hardware_rcp/include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use/want to use RCP? Non-blocking, I think it's better to have it findable for the case anyone wants to use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bootrom.c depends on it. This is required.
I wanted to have the approval completed by a person with Collaborator privileges, but I am unable to contact them, so I would like to ask the two people I asked to approve the request in the past again. I apologize for bothering you during your busy schedule, but I would appreciate your help. |
Could you take a look? |
Update the Raspberry Pi Pico HAL to be based on the latest release of the upstream SDK (v2.2.0).
This PR also changes the default delay multiplier for the external oscillator to match the SDK's default, which first changed in SDK v2.1.1.
#87513 is superseded by this PR.