Skip to content

board: Rename raytac_an54l15q_db to raytac_an54lq_db_15 #94252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

board: Rename raytac_an54l15q_db to raytac_an54lq_db_15 #94252

merged 1 commit into from
Oct 22, 2025

Conversation

@RaytacStanley
Copy link
Contributor

Renamed Raytac AN54L15Q-DB-15 to AN54LQ-DB-15.

This change renames the demo board to align with the certified product
name required for regulatory compliance and to keep naming consistent
across the product series.

@zephyrbot zephyrbot added area: Watchdog Watchdog area: Samples Samples area: ADC Analog-to-Digital Converter (ADC) labels Aug 8, 2025
@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch 2 times, most recently from 06c23ec to a226cc6 Compare August 8, 2025 06:09
@kartben
Copy link
Contributor

kartben commented Aug 8, 2025 •
edited
Loading

You need to add the board to https://github.com/zephyrproject-rtos/zephyr/blob/4c8a69df1a76ea07552cb3b0aa52b545af61f432/boards/deprecated.cmake, mention this change in the migration guide, track the future removal of the deprecated entry in #94255, and also redirect doc page by means of adding an entry in https://github.com/zephyrproject-rtos/zephyr/blob/4c8a69df1a76ea07552cb3b0aa52b545af61f432/doc/_extensions/zephyr/html_redirects.py

@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch from a226cc6 to a96ae45 Compare August 8, 2025 09:22
@RaytacStanley
Copy link
Contributor Author

@kartben Do I need to save the board with the old name, then add a new board and declare it in boards/deprecated.cmake?

@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch from a96ae45 to beaf48a Compare August 8, 2025 09:54
@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Aug 8, 2025
@zephyrbot zephyrbot requested review from cfriedt and jhedberg August 8, 2025 09:55
@kartben kartben requested a review from nordicjm August 8, 2025 11:35
nordicjm
nordicjm reviewed Aug 12, 2025
View reviewed changes
boards/raytac/an54lq_db_15/Kconfig Outdated
on peripheral specific symbols.

endif #BOARD_RAYTAC_AN54L15Q_DB_NRF54L15_CPUAPP_NS
endif #BOARD_RAYTAC_AN54LQ_DB_15_NRF54L15_CPUAPP_NS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endif #BOARD_RAYTAC_AN54LQ_DB_15_NRF54L15_CPUAPP_NS
endif # BOARD_RAYTAC_AN54LQ_DB_15_NRF54L15_CPUAPP_NS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your correction, I have fixed this issue.

nordicjm
nordicjm previously approved these changes Aug 12, 2025
View reviewed changes
@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch from beaf48a to 4048675 Compare August 12, 2025 07:30
@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch 2 times, most recently from 41e774f to 52fe5f6 Compare August 13, 2025 04:29
@kartben
Copy link
Contributor

kartben commented Aug 13, 2025 •
edited
Loading

Please don't forget the comment from earlier:

and also redirect doc page by means of adding an entry in doc/_extensions/zephyr/html_redirects.py

@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch 2 times, most recently from 3e4df1a to 957ae85 Compare August 13, 2025 11:43
@RaytacStanley
Copy link
Contributor Author

@kartben I'm still not sure what "redirect doc page by means of adding an entry in doc/_extensions/zephyr/html_redirects.py" means. Is there a more detailed step-by-step guide on how to do this?

@kartben
Copy link
Contributor

kartben commented Aug 13, 2025

@kartben I'm still not sure what "redirect doc page by means of adding an entry in doc/_extensions/zephyr/html_redirects.py" means. Is there a more detailed step-by-step guide on how to do this?

@RaytacStanley sorry, was on my phone when initially typing this
the file is actually doc/_scripts/redirects.py, sorry. Should be a lot more straightforward for you to figure out what needs to be added there! Thanks!

@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch from 0b6c0f5 to 7ae8716 Compare August 19, 2025 09:29
@kartben
Copy link
Contributor

kartben commented Aug 20, 2025

Looks like this is not a rename anymore in the most recent iterations of this PR, and the original board is now being kept?
https://builds.zephyrproject.io/zephyr/pr/94252/docs/boards/index.html#vendor=raytac&name=an54

@RaytacStanley
Copy link
Contributor Author

@kartben I initially deleted the old board. However, it kept causing a "Data conflict". If you want to merge, you must fix the problem first." I think I couldn't just delete the AN54L15Q_DB board, so I put it back. Should I delete the AN54L15Q_DB board?

@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch from 7ae8716 to 2290ad7 Compare September 3, 2025 10:54
@zephyrbot zephyrbot requested a review from JarmouniA September 3, 2025 10:55
@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch from 2290ad7 to e5f0871 Compare September 3, 2025 11:05
@kartben
Copy link
Contributor

kartben commented Sep 8, 2025

Should I delete the AN54L15Q_DB board?

yes - there is no reason why this shouldn't work. If you encounter issues again, maybe you could share the specific error message you're getting? Thanks!

@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch 3 times, most recently from 554d97f to 4a03e23 Compare September 10, 2025 05:57
@RaytacStanley
Copy link
Contributor Author

Hi @kartben,
After I deleted the an54l15q_db board, the Documentation Build (HTML) got a false message like this: release-notes-4.2.rst:653: WARNING: zephyr: board reference target not found: raytac_an54l15q_db [ref.board]. Do you know how I can do it?

kartben
kartben reviewed Sep 10, 2025
View reviewed changes
doc/releases/release-notes-4.2.rst
* Raytac Corporation

* :zephyr:board:`raytac_an54l15q_db` (``raytac_an54l15q_db``)
* :zephyr:board:`raytac_an54lq_db_15` (``raytac_an54lq_db_15``)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* :zephyr:board:`raytac_an54lq_db_15` (``raytac_an54lq_db_15``)
* AN54L15Q-DB (``raytac_an54l15q_db``)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused here. The raytac_an54l15q_db has been deleted. Should I need to change it to AN54L15Q-DB (raytac_an54l15q_db)?

boards/raytac/an54l15q_db/raytac_an54l15q_db_nrf54l15_cpuapp_ns.yaml Outdated
# Copyright (c) 2025 Nordic Semiconductor ASA
# Copyright (c) 2025 Raytac Corporation.
# SPDX-License-Identifier: Apache-2.0
# SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong license :)

@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch from 4a03e23 to d7004ef Compare September 10, 2025 07:16
@RaytacStanley
Copy link
Contributor Author

@kartben After deleting an54l15q_db, the following problem will appear:
image

@kartben kartben force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch from d7004ef to ac648f4 Compare September 15, 2025 15:33
@kartben
Copy link
Contributor

kartben commented Sep 15, 2025

@RaytacStanley that's because these files have just been reformatted, so Github is telling us: what you are renaming in this PR has actually changed since you created the commit doing the rename. I just rebased (and interestingly the Github CLI has no issue whatsoever and didn't even ask me to resolve a conflict...) so it should now be ok.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@RaytacStanley
Copy link
Contributor Author

@kartben, I received numerous error messages a few days ago. Is there anything I need to do?
image
image

@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch from ac648f4 to 52b26f9 Compare October 17, 2025 03:13
@zephyrbot zephyrbot added area: Tests Issues related to a particular existing or missing test area: Boards/SoCs labels Oct 17, 2025
@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch from 52b26f9 to e3b3bae Compare October 17, 2025 03:30
@RaytacStanley
board: Rename raytac_an54l15q_db to raytac_an54lq_db_15
bea1d47 
Renamed raytac_an54l15q_db to raytac_an54lq_db_15.

Signed-off-by: Stanley Huang <[email protected]>
@RaytacStanley RaytacStanley force-pushed the rename_an54l15q_db_to_an54lq_db_15 branch from e3b3bae to bea1d47 Compare October 17, 2025 03:37
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kartben kartben requested a review from nordicjm October 21, 2025 23:57
@RaytacStanley
Copy link
Contributor Author

@kartben Thanks!

@kartben kartben merged commit a78bf4f into zephyrproject-rtos:main Oct 22, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartben kartben kartben approved these changes

@nordicjm nordicjm nordicjm approved these changes

@anangl anangl Awaiting requested review from anangl

@katsuster katsuster Awaiting requested review from katsuster

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

@nashif nashif Awaiting requested review from nashif

@cfriedt cfriedt Awaiting requested review from cfriedt

@jhedberg jhedberg Awaiting requested review from jhedberg

@carlescufi carlescufi Awaiting requested review from carlescufi

@gmarull gmarull Awaiting requested review from gmarull

@JarmouniA JarmouniA Awaiting requested review from JarmouniA

Assignees

@kartben kartben

Labels

area: ADC Analog-to-Digital Converter (ADC) area: Boards/SoCs area: Documentation Infrastructure area: Samples Samples area: Tests Issues related to a particular existing or missing test area: Watchdog Watchdog Release Notes To be mentioned in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RaytacStanley @kartben @nordicjm @zephyrbot