driver: dma: dma_silabs_siwx91x: Add pm device support for dma driver #94374

fimohame · 2025-08-12T07:09:35Z

This commit enables the pm device driver support for the dma_silabs_siwx91x driver.

drivers/dma/dma_silabs_siwx91x.c

sonarqubecloud · 2025-08-19T07:00:18Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Martinhoff-maker · 2025-09-05T14:46:58Z

As discussed, since we agree to use CONFIG_PM_DEVICE=y and having in mind that going to sleep will completely turn off the device without any register retention on siwx917 board.

Martinhoff-maker · 2025-09-05T15:18:56Z

drivers/dma/dma_silabs_siwx91x.c

+			return -EBUSY;
+		}
+	} else if (IS_ENABLED(CONFIG_PM_DEVICE) && (action == PM_DEVICE_ACTION_SUSPEND)) {
+		return 0;


As explained here: #94695 (comment)
You also need to turn off clocks as I understand for the future with pm device runtime mode. (Because you can suspend the device without sleeping)

jerome-pouiller · 2025-09-05T16:51:13Z

drivers/dma/dma_silabs_siwx91x.c

-	}
+	if (action == PM_DEVICE_ACTION_RESUME) {
+		ret = clock_control_on(cfg->clock_dev, cfg->clock_subsys);
+		if (ret) {


clock_control_on() may return -EALREADY which is not really an error (I know... this API is annoying).

drivers/dma/dma_silabs_siwx91x.c

jerome-pouiller · 2025-09-25T09:44:24Z

drivers/dma/dma_silabs_siwx91x.c

+	case PM_DEVICE_ACTION_SUSPEND:
+		break;
+	case PM_DEVICE_ACTION_TURN_ON:
+		ret = clock_control_on(cfg->clock_dev, cfg->clock_subsys);


Do we need to turn this clock in PM_DEVICE_ACTION_TURN_ON, or this can be done later in PM_DEVICE_ACTION_RESUME?

I think it was discussed to place it here

Martinhoff-maker · 2025-10-08T09:39:43Z

dts/arm/silabs/siwg917.dtsi

+			power-domains = <&siwx91x_soc_pd>;
+			zephyr,pm-device-runtime-auto;


don't you think we can also apply it to ulpdma ? in ps4 sleep state, we will have have the same behavior than the HP uDMA (no register retention)

Martinhoff-maker · 2025-10-08T15:05:23Z

drivers/dma/dma_silabs_siwx91x.c


-	/* Connect the DMA interrupt */
-	cfg->irq_configure();
+		cfg->irq_configure();


we don't need to reconfigure the irq after each wake-up, are we ? this can be done only in the init function IMO

Martinhoff-maker

Just to make sure that we got the same understanding (and it's between all the PM PR):

Since you got no runtime get and put inside of this uDMA driver, you consider that the device will always be suspended or turned off if the power domain is suspended ? Then since we are on the same power-domain than the peripheral that use the uDMA, when you will do a "get" inside of this peripheral, it will turn on the power domain and then put the uDMA from OFF to suspended (but that will be good since everything's is alive in our "suspended" mode) ?

fimohame · 2025-10-17T11:13:27Z

I have updated with pm policy state lock get and put for the driver.

…driver This commit enables the pm policy state lock support for the dma_silabs_siwx91x driver. Signed-off-by: S Mohamed Fiaz <[email protected]>

sonarqubecloud · 2025-10-17T11:42:45Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Martinhoff-maker · 2025-10-17T13:13:13Z

I don't think we want to use pm_policy because it's going back to System managed PM. Why don't you used pm_device_runtime_get() instead ?

Martinhoff-maker · 2025-10-17T15:27:50Z

Edit: After discussing with @asmellby, I think that using pm_policy lock is mandatory. that's ok. how do you test that it works properly ?

smalae · 2025-10-19T12:12:35Z

drivers/dma/dma_silabs_siwx91x.c

 					      */
 };

+static void siwx91x_dma_pm_policy_state_lock_get(const struct device *dev)


what is the use of *dev in this function?

Martinhoff-maker · 2025-10-20T08:25:58Z

drivers/dma/dma_silabs_siwx91x.c

 	}

+	/* Get the power management policy state lock */
+	siwx91x_dma_pm_policy_state_lock_get(dev);


I actually implement PM in GPDMA and see one source of error. In the DMA api definition in zephyr, the user can call dma_start on an already started transfer and it should return no error. Then you will get multiple lock and never going to sleep again. I think you need to take the look only if you didn't have an already running DMA on this channel. Btw, this is he same for dma_stop().

fimohame force-pushed the device_pm_silabs_siwx91x_dma branch 5 times, most recently from c73b89c to 620f008 Compare August 12, 2025 09:28

fimohame marked this pull request as ready for review August 12, 2025 09:33

zephyrbot added platform: Silabs Silicon Labs area: DMA Direct Memory Access labels Aug 12, 2025

zephyrbot requested review from Martinhoff-maker, asmellby, jerome-pouiller, jhedberg and teburd August 12, 2025 09:34

zephyrbot assigned jhedberg and asmellby Aug 12, 2025

jerome-pouiller reviewed Aug 12, 2025

View reviewed changes

drivers/dma/dma_silabs_siwx91x.c Show resolved Hide resolved

fimohame force-pushed the device_pm_silabs_siwx91x_dma branch from 620f008 to e603e6d Compare August 12, 2025 10:31

fimohame requested a review from jerome-pouiller August 12, 2025 10:32

fimohame force-pushed the device_pm_silabs_siwx91x_dma branch 3 times, most recently from 0a0e6e1 to 0ac614f Compare August 19, 2025 06:34

Martinhoff-maker previously approved these changes Sep 5, 2025

View reviewed changes

Martinhoff-maker reviewed Sep 5, 2025

View reviewed changes

jerome-pouiller reviewed Sep 5, 2025

View reviewed changes

drivers/dma/dma_silabs_siwx91x.c Show resolved Hide resolved

fimohame marked this pull request as draft September 24, 2025 06:50

fimohame force-pushed the device_pm_silabs_siwx91x_dma branch from 0ac614f to cc83786 Compare September 24, 2025 20:29

fimohame dismissed Martinhoff-maker’s stale review via 2701c32 September 24, 2025 20:40

fimohame force-pushed the device_pm_silabs_siwx91x_dma branch 2 times, most recently from 2701c32 to 569979a Compare September 24, 2025 20:42

fimohame marked this pull request as ready for review September 25, 2025 07:23

fimohame requested review from Martinhoff-maker and jerome-pouiller September 25, 2025 07:25

fimohame force-pushed the device_pm_silabs_siwx91x_dma branch from 569979a to 845009c Compare September 25, 2025 09:22

jerome-pouiller reviewed Sep 25, 2025

View reviewed changes

fimohame mentioned this pull request Oct 7, 2025

driver: i2s: i2s_silabs_siwx91x: Add pm device support for i2s driver #96008

Open

Martinhoff-maker reviewed Oct 8, 2025

View reviewed changes

fimohame force-pushed the device_pm_silabs_siwx91x_dma branch from 845009c to b34cfa4 Compare October 17, 2025 10:48

zephyrbot added the area: Boards/SoCs label Oct 17, 2025

fimohame force-pushed the device_pm_silabs_siwx91x_dma branch 3 times, most recently from 3e0728e to b91c743 Compare October 17, 2025 11:08

driver: dma: dma_silabs_siwx91x: Add pm policy state support for dma …

33452cd

…driver This commit enables the pm policy state lock support for the dma_silabs_siwx91x driver. Signed-off-by: S Mohamed Fiaz <[email protected]>

fimohame force-pushed the device_pm_silabs_siwx91x_dma branch from b91c743 to 33452cd Compare October 17, 2025 11:14

fimohame requested review from Martinhoff-maker and jerome-pouiller October 17, 2025 11:14

smalae reviewed Oct 19, 2025

View reviewed changes

Martinhoff-maker reviewed Oct 20, 2025

View reviewed changes

		power-domains = <&siwx91x_soc_pd>;
		zephyr,pm-device-runtime-auto;

driver: dma: dma_silabs_siwx91x: Add pm device support for dma driver #94374

Are you sure you want to change the base?

driver: dma: dma_silabs_siwx91x: Add pm device support for dma driver #94374

Conversation

fimohame commented Aug 12, 2025

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 19, 2025

Quality Gate passed

Uh oh!

Martinhoff-maker commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fimohame Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Martinhoff-maker left a comment

Choose a reason for hiding this comment

Uh oh!

fimohame commented Oct 17, 2025

Uh oh!

sonarqubecloud bot commented Oct 17, 2025

Quality Gate passed

Uh oh!

Martinhoff-maker commented Oct 17, 2025

Uh oh!

Martinhoff-maker commented Oct 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Martinhoff-maker Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Martinhoff-maker commented Sep 5, 2025 •

edited

Loading

fimohame Sep 25, 2025 •

edited

Loading

Martinhoff-maker Oct 20, 2025 •

edited

Loading