Skip to content

Conversation

Orange-Murker
Copy link

This driver adds support for the Infineon FM25XXX series of FRAM chips.

Has been tested on Infineon FM25CL64B-G.

Copy link

@Orange-Murker Orange-Murker requested a review from dsseng August 18, 2025 14:36
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unnecessary locking around the single SPI transaction.

@Orange-Murker
Copy link
Author

Please remove the unnecessary locking around the single SPI transaction.

Done

@henrikbrixandersen
Copy link
Member

Please rebase on main to resolve the CI issues.

@Orange-Murker
Copy link
Author

Please rebase on main to resolve the CI issues.

Done. Also removed a now unused variable

Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just remembered - you need to add a build-only test to tests/drivers/build_all/eeprom/ as well.

@Orange-Murker
Copy link
Author

What exactly needs to be added there? I don't see any other tests for specific FRAM/EEPROM chips in that directory

@henrikbrixandersen
Copy link
Member

What exactly needs to be added there? I don't see any other tests for specific FRAM/EEPROM chips in that directory

You need to add an entry to https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/drivers/build_all/eeprom/app.overlay to ensure the driver gets built in CI.

@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Oct 8, 2025
@zephyrbot zephyrbot requested a review from nashif October 8, 2025 14:30
This driver adds support for the Infineon FM25XXX series of chips.
Has been tested on Infineon FM25CL64B-G.

Signed-off-by: Luna Pes <[email protected]>
Copy link

sonarqubecloud bot commented Oct 8, 2025

Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Bindings area: EEPROM area: Tests Issues related to a particular existing or missing test platform: Infineon Infineon Technologies AG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants