posix: use posix_time.h and posix_signal.h #95226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
cfriedt
changed the title
cfriedt
force-pushed
the
rename-time-h-to-posix-time-h
branch
from
2313eed to
85942d5
Compare
zephyrbot
requested review from
aescolar,
keith-packard,
nashif,
stephanosio and
ycsin
|
cfriedt
force-pushed
the
rename-time-h-to-posix-time-h
branch
from
85942d5 to
68ba062
Compare
|
|
It looks like #95285 is causing the build failure in twister-build (1). |
|
The failure in twister build (7) is the result of interdependency between current https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html I'll see if I can remove that interdependency in a separate PR. If it is not possible, then the signal.h changes will be added to this PR. |
cfriedt
commented
Sep 1, 2025
cfriedt
force-pushed
the
rename-time-h-to-posix-time-h
branch
5 times, most recently
from
38a73f6 to
128f1bc
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_nxp
DNM (manifest)
cfriedt
changed the title
github-actions
bot
removed
manifest
manifest-hal_nxp
DNM (manifest)
cfriedt
commented
Sep 10, 2025
cfriedt
commented
Sep 10, 2025
Create a header for satisfying POSIX conformance requirements of signal.h that is named posix_signal.h rather than signal.h. The primary reason for doing so, is that the de-facto owner of signal.h is the C library. This new header only defines required POSIX symbols that form a strict superset over the ISO C signal.h symbols. Signed-off-by: Chris Friedt <[email protected]>
To avoid conflicts between the C library's `time.h` and signal.h use an "override" header (when necessary) for C libraries that do not themselves provide POSIX definitions in `time.h` or `signal.h`. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
rename-time-h-to-posix-time-h
branch
from
28c80f3 to
2b318b2
Compare
|
@stephanosio - this should basically be ready for you to review. Only minor changes since the last revision. |
|
jhedberg
approved these changes
Sep 18, 2025
fabiobaltieri
approved these changes
Sep 18, 2025
ycsin
approved these changes
Sep 22, 2025
|
@stephanosio - are you able to review? If not, is it ok if I reassign to e.g. Keith or someone else? |
|
Just adding the |
|
And, oddly, adding the dev-review label causes CI to fail 😅 . Hopefully, removing it will help. |
|
Self-assigning this, since it
|
fabiobaltieri
merged commit 1eb5c97
into
zephyrproject-rtos:main
37 of 38 checks passed
yashi
added a commit
to yashi/libcsp
that referenced
this pull request
Oct 3, 2025
Zephyr's POSIX time support has been updated (PR #95226) to provide a new header <zephyr/posix/posix_time.h>. This change ensures that <time.h> can be included safely, even when a libc previously provided its own conflicting version. To maintain compatibility before and after the PR, this patch uses __has_include to prefer <time.h> when <zephyr/posix/posix_time.h> is available, and falls back to <zephyr/posix/time.h> otherwise. This prevents build errors caused by incompatible or incomplete <time.h> implementations in some environments. References: – zephyrproject-rtos/zephyr#95226 – zephyrproject-rtos/zephyr#96911 – https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005finclude.html Signed-off-by: Yasushi SHOJI <[email protected]>
yashi
added a commit
to libcsp/libcsp
that referenced
this pull request
Oct 3, 2025
Zephyr's POSIX time support has been updated (PR #95226) to provide a new header <zephyr/posix/posix_time.h>. This change ensures that <time.h> can be included safely, even when a libc previously provided its own conflicting version. To maintain compatibility before and after the PR, this patch uses __has_include to prefer <time.h> when <zephyr/posix/posix_time.h> is available, and falls back to <zephyr/posix/time.h> otherwise. This prevents build errors caused by incompatible or incomplete <time.h> implementations in some environments. References: – zephyrproject-rtos/zephyr#95226 – zephyrproject-rtos/zephyr#96911 – https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005finclude.html Signed-off-by: Yasushi SHOJI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid conflicts between the C library's
time.handsignal.huse an "override" header (when necessary) for C libraries that do not themselves provide POSIX definitions intime.horsignal.h.In order to achieve that, provide
posix_time.handposix_signal.hthat define only the POSIX symbols that are not defined by ISO C.https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/time.h.html
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html
Required by #88547