posix: use posix_time.h and posix_signal.h [v2] #96589

cfriedt · 2025-09-25T20:17:27Z

This is version 2 of #95226

To avoid conflicts between the C library's time.h and signal.h use an "override" header (when necessary) for C libraries that do not themselves provide POSIX definitions in time.h or signal.h.

In order to achieve that, provide posix_time.h and posix_signal.h that define only the POSIX symbols that are not defined by ISO C.

https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/time.h.html
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html

Required by #88547

Testing Done:

west build -p -b native_sim/native tests/net/wifi/configs -T wifi.build.hostapd_ap
west build -p -b native_sim/native tests/posix/signals -T portability.posix.signals.big_nsig
twister -c -O /tmp/twister-out -T tests/posix -T tests/lib/c_lib -T tests/net/wifi
Deleting output directory /tmp/twister-out
INFO    - Using Ninja..
INFO    - Zephyr version: v4.2.0-4459-g0b25fd0fd992
INFO    - Using 'zephyr' toolchain.
INFO    - Selecting default platforms per testsuite scenario
INFO    - Building initial testsuite list...
INFO    - Writing JSON report /tmp/twister-out/testplan.json
INFO    - JOBS: 32
INFO    - Adding tasks to the queue...
INFO    - Added initial list of jobs to queue
INFO    - Total complete:  1615/1615  100%  built (not run):   13, filtered: 4979, failed:    0, error:    0

Also, grepped through all module sources to make sure that none were still pulling in zephyr/posix/time.h or zephyr/posix/signal.h.

github-actions · 2025-09-25T20:20:47Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hostap	zephyrproject-rtos/hostap@`0798bf0`	zephyrproject-rtos/hostap@`61182a4`	zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

cfriedt · 2025-09-25T20:27:37Z

Identical to the previous version aside from

Include manifest: update hostap module to correct time.h and signal.h paths #96587 in this PR, to maintain continuity of build w.r.t. the hostap module
changed <zephyr/posix/time.h> to <time.h> in samples/net/ocpp/src/main.c (the OCPP change was merged a few days after posix: use posix_time.h and posix_signal.h #95226 was created)
undefine sigaddset(), sigdelset(), and sigismember() macros in picolibc/include/signal.h since they are non-conformant
mitigated 2 code sonar warnings about casting const * to *

Assuming that the `posix` tag will trigger `posix` tests to be run when this testsuite is changed. Signed-off-by: Chris Friedt <[email protected]>

Create a header for satisfying POSIX conformance requirements of time.h that is named posix_time.h rather than time.h. The primary reason for doing so, is that the de-facto owner of time.h is the C library. This new header only defines required POSIX symbols that form a strict superset over the ISO C time.h symbols. V2 Signed-off-by: Chris Friedt <[email protected]>

Create a header for satisfying POSIX conformance requirements of signal.h that is named posix_signal.h rather than signal.h. The primary reason for doing so, is that the de-facto owner of signal.h is the C library. This new header only defines required POSIX symbols that form a strict superset over the ISO C signal.h symbols. V2 Signed-off-by: Chris Friedt <[email protected]>

cfriedt · 2025-09-27T12:32:46Z

fixed error in test_signal_strsignal to use correct values for SIGHUP and SIGSYS

Update the hostap module to use non-prefixed paths for the ISO C time.h and signal.h headers. Signed-off-by: Chris Friedt <[email protected]>

To avoid conflicts between the C library's `time.h` and signal.h use an "override" header (when necessary) for C libraries that do not themselves provide POSIX definitions in `time.h` or `signal.h`. V2 Signed-off-by: Chris Friedt <[email protected]>

cfriedt · 2025-09-27T13:42:42Z

add check signo_fits() in signal.c for detecting a sigset_t that is too small
skipped testing SIGRTMIN - SIGRTMAX when the size of sigset_t is insufficient (e.g. some libc's use 1 long on 32-bit systems, so cannot represent realtime signals)
undefine sigaddset(), sigdelset(), and sigismember() macros in newlib/include/signal.h since they are non-conformant

sonarqubecloud · 2025-09-27T14:07:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.2% Duplication on New Code

See analysis details on SonarQube Cloud

cfriedt · 2025-09-28T13:46:56Z

@jukkar @ycsin @fabiobaltieri @jhedberg - please (re-)review when you have time

cfriedt · 2025-09-30T10:39:38Z

@stephanosio - can you review this today? If not I'll self-assign again.

cfriedt force-pushed the rename-time-h-to-posix-time-h-v2 branch from e8704a7 to 5e37e7e Compare September 25, 2025 20:19

github-actions bot added manifest manifest-hostap DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Sep 25, 2025

cfriedt force-pushed the rename-time-h-to-posix-time-h-v2 branch 2 times, most recently from 8dd1251 to dc5dc6a Compare September 25, 2025 21:35

cfriedt added 3 commits September 25, 2025 17:39

tests: net: wifi: configs: add posix tag, since there is a dependency

7475a87

Assuming that the `posix` tag will trigger `posix` tests to be run when this testsuite is changed. Signed-off-by: Chris Friedt <[email protected]>

cfriedt force-pushed the rename-time-h-to-posix-time-h-v2 branch 3 times, most recently from 33ad822 to fa6eb36 Compare September 27, 2025 12:30

cfriedt changed the title ~~posix: headers: create a more conformant posix_time.h~~ posix: use posix_time.h and posix_signal.h [v2] Sep 27, 2025

github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Sep 27, 2025

manifest: update hostap module to correct time.h and signal.h paths

4203cc3

Update the hostap module to use non-prefixed paths for the ISO C time.h and signal.h headers. Signed-off-by: Chris Friedt <[email protected]>

cfriedt force-pushed the rename-time-h-to-posix-time-h-v2 branch 2 times, most recently from 615605c to 911602d Compare September 27, 2025 13:29

cfriedt force-pushed the rename-time-h-to-posix-time-h-v2 branch from 911602d to 0b25fd0 Compare September 27, 2025 13:42

cfriedt marked this pull request as ready for review September 27, 2025 14:46

cfriedt mentioned this pull request Sep 27, 2025

manifest: update hostap module to correct time.h and signal.h paths #96587

Closed

zephyrbot added area: POSIX POSIX API Library area: C Library C Standard Library area: Networking area: OCPP labels Sep 27, 2025

zephyrbot added the area: Build System label Sep 27, 2025

zephyrbot requested review from 57300, aescolar, jeremybettis, jukkar, kartben, keith-packard, krish2718, MaochenWang1, nashif, nordicjm, rlubos, ssekar15, stephanosio, tejlmand and ycsin September 27, 2025 14:48

zephyrbot assigned stephanosio Sep 27, 2025

This was referenced Sep 28, 2025

posix: Missing signal.h header file #96566

Closed

posix: options: add custom Zephyr POSIX subprofile #88547

Draft

cfriedt mentioned this pull request Sep 28, 2025

[noup] zephyr: remove stale comment that mentions zepyr/posix/time.h zephyrproject-rtos/hostap#106

Open

krish2718 approved these changes Sep 29, 2025

View reviewed changes

jukkar approved these changes Sep 29, 2025

View reviewed changes

jhedberg approved these changes Sep 29, 2025

View reviewed changes

stephanosio assigned cfriedt and unassigned stephanosio Sep 30, 2025

stephanosio approved these changes Sep 30, 2025

View reviewed changes

jhedberg merged commit 5cbb2a4 into zephyrproject-rtos:main Oct 1, 2025
56 checks passed

dkouba-atym mentioned this pull request Oct 1, 2025

Build with CONFIG_POSIX_API=y fails on main #96886

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

posix: use posix_time.h and posix_signal.h [v2] #96589

posix: use posix_time.h and posix_signal.h [v2] #96589

cfriedt commented Sep 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

cfriedt commented Sep 25, 2025 •

edited

Loading

Uh oh!

cfriedt commented Sep 27, 2025

Uh oh!

cfriedt commented Sep 27, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Sep 27, 2025

Uh oh!

cfriedt commented Sep 28, 2025

Uh oh!

cfriedt commented Sep 30, 2025 •

edited by kartben

Loading

Uh oh!

Uh oh!

Uh oh!

posix: use posix_time.h and posix_signal.h [v2] #96589

posix: use posix_time.h and posix_signal.h [v2] #96589

Conversation

cfriedt commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cfriedt commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cfriedt commented Sep 27, 2025

Uh oh!

cfriedt commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 27, 2025

Quality Gate passed

Uh oh!

cfriedt commented Sep 28, 2025

Uh oh!

cfriedt commented Sep 30, 2025 • edited by kartben Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cfriedt commented Sep 25, 2025 •

edited

Loading

github-actions bot commented Sep 25, 2025 •

edited

Loading

cfriedt commented Sep 25, 2025 •

edited

Loading

cfriedt commented Sep 27, 2025 •

edited

Loading

cfriedt commented Sep 30, 2025 •

edited by kartben

Loading