boards: nordic: Add initial support for nRF54LM20A/ns #95743

degjorva · 2025-09-09T14:09:12Z

Add board files for nRF54LM20A/ns.
Update existing nRF54LM20A board files to support this.

github-actions · 2025-09-09T14:09:57Z

Hello @degjorva, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

boards/nordic/nrf54lm20dk/board.cmake

boards/nordic/nrf54lm20dk/Kconfig

boards/nordic/nrf54lm20dk/Kconfig.defconfig

boards/nordic/nrf54lm20dk/nrf54lm20dk_nrf54lm20a_cpuapp_ns.yaml

boards/nordic/nrf54lm20dk/nrf54lm20dk_nrf54lm20a_cpuapp_ns_defconfig

dts/arm/nordic/nrf54lm20a_enga_cpuapp.dtsi

dts/vendor/nordic/nrf54lm20a_ns_partition.dtsi

boards/nordic/nrf54lm20dk/Kconfig.defconfig

boards/nordic/nrf54lm20dk/nrf54lm20dk_nrf54lm20a_cpuapp_ns.dts

tomi-font · 2025-09-26T12:10:42Z

boards/nordic/nrf54lm20dk/nrf54lm20dk_nrf54lm20a_cpuapp_ns.dts

+/* Get a node label for wi-fi spi to use in shield files */
+wifi_spi: &spi22 {};


Maybe move it from nrf54lm20dk_nrf54lm20a_cpuapp.dts to nrf54lm20dk_nrf54lm20a-common.dtsi?

dts/vendor/nordic/nrf54lm20a_ns_partition.dtsi

nordicjm · 2025-09-30T07:47:20Z

boards/nordic/nrf54lm20dk/nrf54lm20a_cpuapp_common.dtsi

-		};
-	};
-};
+/* TF-M partitions are defined in the NS board DTS file */


comment not needed and doesn't even apply to secure board target

nordicjm · 2025-09-30T07:49:13Z

boards/nordic/nrf54lm20dk/nrf54lm20dk_nrf54lm20a_cpuapp_ns.dts

+&bt_hci_controller {
+	status = "disabled";
+};
+
+&uart30 {
+	/* Disable so that TF-M can use this UART */
+	status = "disabled";
+};


why can't these definitions be moved from the common file to the normal cpuapp file so that they don't need to be disabled here?

nordicjm · 2025-09-30T07:49:26Z

boards/nordic/nrf54lm20dk/nrf54lm20dk_nrf54lm20a_cpuapp_ns.dts

+		zephyr,entropy = &psa_rng;
+	};
+
+	/delete-node/ rng;


as other comment

nordicjm · 2025-09-30T07:52:21Z

dts/vendor/nordic/nrf54lm20a_ns_partition.dtsi

+		/* nRF54LM20A has 2036 kB of non-volatile memory (RRAM) but the last
+		 * 96 kB are reserved for the FLPR MCU.


no, no no no, we agreed not to do this again @carlescufi

Right this comment contains no useful information. What did we agree not to do, with who, when, where? What is supposed to be done differently? Why? How is it supposed to be done instead? Where was that added as a requirement for the implementation of TF-m?

no flpr reservation in normal builds without flpr, use full RRAM for application core

That will mean the upstream TF-m flash map will cover the entire RRAM as well. I am no expert on the FLPR, but won't that cause issues with the reserved memory?

@tomi-font for comment, for non-TF-M i.e. the normal cpuapp it has no impact from TF-M

? Honestly I have no idea, and here I believe @degjorva is just copying what's done for nRF54L15. What are you even asking @nordicjm ? + cc @Vge0rge @frkv

should a flpr section be removed from the end of NVM in the TF-M images i.e. is that what has been done with the upstream TF-M partition file?

In upstream TF-m we use the layout that is shown in this PR, it is the layout we have used for all 54L-series devices. As far as I can understand from how dts works that is also how it needs to be due to the FLPR core, but I could be wrong. I checked with @Vge0rge which did not have any more information.

Since no one knows I will stick with this here and create a follow up task to investigate what the correct solution is in regards to the FLPR sections and if they are not needed to remove them from all 54L devices. @Vge0rge @tomi-font @nordicjm

nordicjm · 2025-09-30T07:52:35Z

dts/vendor/nordic/nrf54lm20a_partition.dtsi

+		/* nRF54LM20A has 2036 kB of non-volatile memory (RRAM) but the last
+		 * 96 kB are reserved for the FLPR MCU, so we have ~1940 kB available.
+		 */


as above, no

Same as above

github-actions · 2025-10-09T13:42:36Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
trusted-firmware-m	zephyrproject-rtos/trusted-firmware-m@`3e12b0c`	zephyrproject-rtos/trusted-firmware-m#150	zephyrproject-rtos/trusted-firmware-m#150/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

degjorva · 2025-10-10T08:54:53Z

Rebase

west.yml

boards/nordic/nrf54lm20dk/nrf54lm20a_cpuapp_common.dtsi

dts/vendor/nordic/nrf54lm20a.dtsi

Update commit id for trusted-firmware-m to bring in support for nRF54LM20A/ns. Signed-off-by: Dag Erik Gjørvad <[email protected]>

Add board files for nRF54LM20A/ns. Update existing nRF54LM20A board files to support this. Signed-off-by: Dag Erik Gjørvad <[email protected]>

sonarqubecloud · 2025-10-10T10:29:19Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added platform: nRF Nordic nRFx area: TF-M ARM Trusted Firmware-M (TF-M) labels Sep 9, 2025

zephyrbot requested review from anangl, d3zd3z, ithinuel, jaz1-nordic, kl-cruz, magp-nordic, masz-nordic, nika-nordic, tomi-font, valeriosetti, Vge0rge and wearyzen September 9, 2025 14:10

zephyrbot assigned d3zd3z Sep 9, 2025

degjorva force-pushed the lm20-ns-target branch 2 times, most recently from e89c955 to f0d3588 Compare September 15, 2025 08:57

tomi-font requested changes Sep 18, 2025

View reviewed changes

degjorva force-pushed the lm20-ns-target branch from f0d3588 to 7211cba Compare September 25, 2025 15:07

zephyrbot requested review from bjarki-andreasen and lstnl September 25, 2025 15:09

degjorva force-pushed the lm20-ns-target branch from 7211cba to 6b7a843 Compare September 25, 2025 15:30

tomi-font requested a review from nordicjm September 26, 2025 11:56

tomi-font requested changes Sep 26, 2025

View reviewed changes

degjorva force-pushed the lm20-ns-target branch from 6b7a843 to b4c8e67 Compare September 26, 2025 14:20

tomi-font previously approved these changes Sep 29, 2025

View reviewed changes

nordicjm reviewed Sep 30, 2025

View reviewed changes

nordicjm requested changes Sep 30, 2025

View reviewed changes

degjorva mentioned this pull request Oct 9, 2025

Cherry-pick required commits to support nRF54LM20A/ns zephyrproject-rtos/trusted-firmware-m#150

Open

degjorva dismissed tomi-font’s stale review via ac7bc67 October 9, 2025 13:40

degjorva force-pushed the lm20-ns-target branch from b4c8e67 to ac7bc67 Compare October 9, 2025 13:40

degjorva requested a review from nordicjm October 9, 2025 13:42

zephyrbot added the area: Boards/SoCs label Oct 9, 2025

github-actions bot added manifest manifest-trusted-firmware-m DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 9, 2025

degjorva force-pushed the lm20-ns-target branch from ac7bc67 to b1ae931 Compare October 9, 2025 14:04

degjorva requested a review from tomi-font October 9, 2025 14:27

degjorva force-pushed the lm20-ns-target branch from b1ae931 to 86a9349 Compare October 10, 2025 08:54

tomi-font requested changes Oct 10, 2025

View reviewed changes

west.yml Show resolved Hide resolved

boards/nordic/nrf54lm20dk/nrf54lm20a_cpuapp_common.dtsi Show resolved Hide resolved

dts/vendor/nordic/nrf54lm20a.dtsi Outdated Show resolved Hide resolved

degjorva added 2 commits October 10, 2025 12:21

manifest: Update commit id for trusted-firmware-m

a7c139e

Update commit id for trusted-firmware-m to bring in support for nRF54LM20A/ns. Signed-off-by: Dag Erik Gjørvad <[email protected]>

boards: nordic: Add initial support for nRF54LM20A/ns

7a81439

Add board files for nRF54LM20A/ns. Update existing nRF54LM20A board files to support this. Signed-off-by: Dag Erik Gjørvad <[email protected]>

degjorva force-pushed the lm20-ns-target branch from 86a9349 to 7a81439 Compare October 10, 2025 10:25

tomi-font approved these changes Oct 10, 2025

View reviewed changes

		/* Get a node label for wi-fi spi to use in shield files */
		wifi_spi: &spi22 {};

		/* nRF54LM20A has 2036 kB of non-volatile memory (RRAM) but the last
		* 96 kB are reserved for the FLPR MCU.

boards: nordic: Add initial support for nRF54LM20A/ns #95743

Are you sure you want to change the base?

boards: nordic: Add initial support for nRF54LM20A/ns #95743

Conversation

degjorva commented Sep 9, 2025

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

degjorva Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

degjorva commented Oct 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 10, 2025

Quality Gate passed

Uh oh!

Uh oh!

degjorva Oct 9, 2025 •

edited

Loading

github-actions bot commented Oct 9, 2025 •

edited

Loading