-
Notifications
You must be signed in to change notification settings - Fork 8k
stm32: tests/samples : add support for nucleo_h753zi on some tests and samples #95744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
depends_on: adc | ||
platform_allow: | ||
- nucleo_l073rz | ||
- nucleo_h753zi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point? it's the same IP as stm32h735g_disco and stm32l496g_disco...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I understand what you mean, but I think it is valid for integration_platforms
, not platform_allow
. Without specifying this board, Twister will not run this test on the NUCLEO_H753ZI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without specifying this board, Twister will not run this test on the NUCLEO_H753ZI.
Exactly my point, we don't need it to, it has no added value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context of this change is to use nucleo_h753zi
as "H7" champion on the test bench, so we need to it to be present everywhere.
Cleaning up the number of boards present in these files is a good point, but we need to think about it more widely and it's likely a point for testing working group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use nucleo_h753zi as "H7" champion on the test bench, so we need to it to be present everywhere.
@erwango I don't think it's a great strategy to add a board like this everywhere without looking at the specifics of each sample/test.
Cleaning up the number of boards present in these files is a good point, but we need to think about it more widely
As a starting point #94585
defined(CONFIG_BOARD_NUCLEO_G431RB) || \ | ||
defined(CONFIG_BOARD_NUCLEO_G474RE) || \ | ||
defined(CONFIG_BOARD_NUCLEO_H743ZI) || \ | ||
defined(CONFIG_BOARD_NUCLEO_H753ZI) || \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole thing needs to be cleaned up, the nodelabel should come from a board/SoC overlay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I agree with you. For this scope, I propose to do this cleanup in a dedicated PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, #81458 would help on this (to avoid multiple overlays).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will propose a PR later incorporating these suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will propose a PR later incorporating these suggestions.
okey
e444ec8
to
ac13a6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 2 main points:
- The easy one: Let's provide always the same and complete header file in overlays (Copyright plus license)
- The one to discuss: Should we remove
nucleo_h743zi
fully from theplatform_allow
? From theintegration_platform
?
tests/drivers/clock_control/stm32_clock_configuration/stm32h7_core/testcase.yaml
Show resolved
Hide resolved
|
ac13a6c
to
9a7bb61
Compare
There is no backward compatibility for testing, plus platform_allow/platform_exclude can be overridden globally with Twister arg |
Important note to users about the obsolescence of NUCLEO_H743ZI. Signed-off-by: Fabrice DJIATSA <[email protected]>
remove nucleo_h743zi from integration_platform and replace with nucleo_h753zi. Signed-off-by: Fabrice DJIATSA <[email protected]>
enable sample to run in CI on nucleo_h753zi. Signed-off-by: Fabrice DJIATSA <[email protected]>
- enable sample to run in CI on nucleo_h753zi. Signed-off-by: Fabrice DJIATSA <[email protected]>
enable sample to run in CI on nucleo_h753zi. related sample: ptp and zperf Signed-off-by: Fabrice DJIATSA <[email protected]>
- add .conf and .overlay files with appropriate configurations for nucleo_h753zi. - enable sample to run in CI on nucleo_h753zi. Signed-off-by: Fabrice DJIATSA <[email protected]>
… in CI enable sample to run in CI on nucleo_h753zi. Signed-off-by: Fabrice DJIATSA <[email protected]>
… board Add various timer nodes to enable the test to run successfully. Signed-off-by: Fabrice DJIATSA <[email protected]>
Add the CONFIG_BOARD_NUCLEO_H753ZI symbol to enable running tests on the NUCLEO_H753ZI board. Signed-off-by: Fabrice DJIATSA <[email protected]>
add .conf and .overlay files with appropriate configurations for nucleo_h753zi. Signed-off-by: Fabrice DJIATSA <[email protected]>
add .conf and .overlay files with appropriate configurations for nucleo_h753zi. Signed-off-by: Fabrice DJIATSA <[email protected]>
Add nucleo_h753zi as an allowed platform to run this test in CI. Signed-off-by: Fabrice DJIATSA <[email protected]>
- enable i2c2 node in dts - add .conf and .overlay with appropriate configurations for nucleo_h753zi. - update testcase.yaml file for CI testing Signed-off-by: Fabrice DJIATSA <[email protected]>
add .overlay file with timers1 node configuration. Signed-off-by: Fabrice DJIATSA <[email protected]>
add overlay with appropriate configuration for nucleo_h753zi Signed-off-by: Fabrice DJIATSA <[email protected]>
add .conf and .overlay with appropriate configurations for nucleo_h753zi. Signed-off-by: Fabrice DJIATSA <[email protected]>
- add .conf and .overlay with appropriate configurations for nucleo_h753zi - update testcase.yaml file for CI testing Signed-off-by: Fabrice DJIATSA <[email protected]>
- add .overlay with appropriate configurations for nucleo_h753zi - update testcase.yaml file for CI testing Signed-off-by: Fabrice DJIATSA <[email protected]>
- add watchdog0 node alias - remove redundant nucleo_h753zi Signed-off-by: Fabrice DJIATSA <[email protected]>
Add support for the RTC, WATCHDOG, and DMA peripherals. These are required for the DMA and RTC, WATCHDOG test drivers. Signed-off-by: Fabrice DJIATSA <[email protected]>
a74199d
to
01f3fe6
Compare
|
This PR adds support for the NUCLEO_H753ZI on several tests and samples for test bench purposes.
It will eventually replace the NUCLEO_H743ZI, which is obsolete, as shown here here