Skip to content

Conversation

djiatsaf-st
Copy link
Contributor

This PR adds support for the NUCLEO_H753ZI on several tests and samples for test bench purposes.
It will eventually replace the NUCLEO_H743ZI, which is obsolete, as shown here here

depends_on: adc
platform_allow:
- nucleo_l073rz
- nucleo_h753zi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point? it's the same IP as stm32h735g_disco and stm32l496g_disco...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I understand what you mean, but I think it is valid for integration_platforms, not platform_allow. Without specifying this board, Twister will not run this test on the NUCLEO_H753ZI.

Copy link
Contributor

@JarmouniA JarmouniA Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without specifying this board, Twister will not run this test on the NUCLEO_H753ZI.

Exactly my point, we don't need it to, it has no added value.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context of this change is to use nucleo_h753zi as "H7" champion on the test bench, so we need to it to be present everywhere.
Cleaning up the number of boards present in these files is a good point, but we need to think about it more widely and it's likely a point for testing working group.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use nucleo_h753zi as "H7" champion on the test bench, so we need to it to be present everywhere.

@erwango I don't think it's a great strategy to add a board like this everywhere without looking at the specifics of each sample/test.

Cleaning up the number of boards present in these files is a good point, but we need to think about it more widely

As a starting point #94585

defined(CONFIG_BOARD_NUCLEO_G431RB) || \
defined(CONFIG_BOARD_NUCLEO_G474RE) || \
defined(CONFIG_BOARD_NUCLEO_H743ZI) || \
defined(CONFIG_BOARD_NUCLEO_H753ZI) || \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole thing needs to be cleaned up, the nodelabel should come from a board/SoC overlay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I agree with you. For this scope, I propose to do this cleanup in a dedicated PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, #81458 would help on this (to avoid multiple overlays).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will propose a PR later incorporating these suggestions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will propose a PR later incorporating these suggestions.

okey

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 main points:

  • The easy one: Let's provide always the same and complete header file in overlays (Copyright plus license)
  • The one to discuss: Should we remove nucleo_h743zi fully from the platform_allow ? From the integration_platform ?

@djiatsaf-st
Copy link
Contributor Author

  • The one to discuss: Should we remove nucleo_h743zi fully from the platform_allow ? From the integration_platform ?
  • integration_platform : For sure, I think we should fully remove nucleo_h743zi to avoid wasted resources and add nucleo_h753zi to reflect actively maintained boards.

  • platform_allow : I think it is a bit more delicate. In the short term, we can keep nucleo_h743zi to maintain backward compatibility for users who may still have it. Then, we can add a comment in the board documentation (https://docs.zephyrproject.org/latest/boards/st/nucleo_h743zi/doc/index.html) or another appropriate place to suggest users switch to nucleo_h753zi for testing purposes. By the end of this year or later, we can fully remove nucleo_h743zi under platform_allow. I think it is safe to proceed this way and potentially avoid any unexpected situations.

@JarmouniA
Copy link
Contributor

we can keep nucleo_h743zi to maintain backward compatibility

There is no backward compatibility for testing, plus platform_allow/platform_exclude can be overridden globally with Twister arg --force-platform.

Important note to users about the obsolescence of NUCLEO_H743ZI.

Signed-off-by: Fabrice DJIATSA <[email protected]>
remove nucleo_h743zi from integration_platform and replace
with nucleo_h753zi.

Signed-off-by: Fabrice DJIATSA <[email protected]>
enable sample to run in CI on nucleo_h753zi.

Signed-off-by: Fabrice DJIATSA <[email protected]>
- enable sample to run in CI on nucleo_h753zi.

Signed-off-by: Fabrice DJIATSA <[email protected]>
enable sample to run in CI on nucleo_h753zi.

related sample: ptp and zperf

Signed-off-by: Fabrice DJIATSA <[email protected]>
- add .conf and .overlay files with appropriate configurations
for nucleo_h753zi.
- enable sample to run in CI on nucleo_h753zi.

Signed-off-by: Fabrice DJIATSA <[email protected]>
… in CI

enable sample to run in CI on nucleo_h753zi.

Signed-off-by: Fabrice DJIATSA <[email protected]>
… board

Add various timer nodes to enable the test to run
successfully.

Signed-off-by: Fabrice DJIATSA <[email protected]>
Add the CONFIG_BOARD_NUCLEO_H753ZI symbol to enable running
tests on the NUCLEO_H753ZI board.

Signed-off-by: Fabrice DJIATSA <[email protected]>
add .conf and .overlay files with appropriate configurations for
nucleo_h753zi.

Signed-off-by: Fabrice DJIATSA <[email protected]>
add .conf and .overlay files with appropriate configurations for
nucleo_h753zi.

Signed-off-by: Fabrice DJIATSA <[email protected]>
Add nucleo_h753zi as an allowed platform to run this
test in CI.

Signed-off-by: Fabrice DJIATSA <[email protected]>
- enable i2c2 node in dts
- add .conf and .overlay with appropriate configurations for
  nucleo_h753zi.
- update testcase.yaml file for CI testing

Signed-off-by: Fabrice DJIATSA <[email protected]>
add .overlay file with timers1 node configuration.

Signed-off-by: Fabrice DJIATSA <[email protected]>
add overlay with appropriate configuration for nucleo_h753zi

Signed-off-by: Fabrice DJIATSA <[email protected]>
add .conf and .overlay with appropriate configurations for
nucleo_h753zi.

Signed-off-by: Fabrice DJIATSA <[email protected]>
- add .conf and .overlay with appropriate configurations for
      nucleo_h753zi
- update testcase.yaml file for CI testing

Signed-off-by: Fabrice DJIATSA <[email protected]>
- add .overlay with appropriate configurations for
  nucleo_h753zi
- update testcase.yaml file for CI testing

Signed-off-by: Fabrice DJIATSA <[email protected]>
- add watchdog0 node alias
- remove redundant nucleo_h753zi

Signed-off-by: Fabrice DJIATSA <[email protected]>
Add support for the RTC, WATCHDOG, and DMA peripherals.
These are required for the DMA and RTC, WATCHDOG test drivers.

Signed-off-by: Fabrice DJIATSA <[email protected]>
Copy link

@erwango erwango assigned erwango and unassigned teburd Sep 30, 2025
@jhedberg jhedberg merged commit 07809ad into zephyrproject-rtos:main Oct 1, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: STM32 ST Micro STM32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants